scalapack: modernize; fix build with cmake4#445431
Merged
markuskowa merged 7 commits intoNixOS:masterfrom Sep 24, 2025
Merged
Conversation
BUILD_SHARED_LIBS and BUILD_STATIC_LIBS are mutually exclusive. Only one needs to be specified. See: https://github.com/Reference-ScaLAPACK/scalapack/blob/25935e1a7e022ede9fd71bd86dcbaa7a3f1846b7/CMakeLists.txt#L113
Hardening disable stackprotector is no longer needed to pass the build on aarch64-darwin.
nixpkgs-ci
bot
added
10.rebuild-linux: 11-100
propagation of blas and lapack is required by scalapack.pc.
nim65s
approved these changes
Sep 23, 2025
Contributor
nim65s
left a comment
nim65s
left a comment
There was a problem hiding this comment.
diff LGTM, thanks !
And I can confirm that this fix build for me on x86_64-linux when applied on staging-next
Contributor
|
part of #445447 |
nixpkgs-ci
bot
added
the
12.approvals: 1
Member
markuskowa
approved these changes
Sep 24, 2025
Member
markuskowa
left a comment
markuskowa
left a comment
There was a problem hiding this comment.
Tested dependent packages on x86_64-linux.
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The last commit fix build with cmake4, one can test it on staging branch.
without the last commit, an error
will raise if build scalapack with cmake4.
Related source where the error raise: https://github.com/Reference-ScaLAPACK/scalapack/blob/25935e1a7e022ede9fd71bd86dcbaa7a3f1846b7/CMAKE/FortranMangling.cmake#L21-L33
Possible cause: cmake4 no longer respect global CMAKE_Fortran_COMPILER in subcommand.
Solution: provide gfortran directly.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.