Skip to content

opencollada: homogenize and patch for cmake4#445329

Merged
LordGrimmauld merged 1 commit intoNixOS:masterfrom
eetwas:master
Sep 23, 2025
Merged

opencollada: homogenize and patch for cmake4#445329
LordGrimmauld merged 1 commit intoNixOS:masterfrom
eetwas:master

Conversation

@eetwas
Copy link
Contributor

@eetwas eetwas commented Sep 22, 2025

As seen in the title.
prePatch is required due to CLRF discrepancies between the patch and source files.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@LordGrimmauld LordGrimmauld self-requested a review September 22, 2025 20:52
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. labels Sep 22, 2025
LordGrimmauld
LordGrimmauld requested changes Sep 22, 2025
View reviewed changes
@grimmauld-bot
Copy link

grimmauld-bot commented Sep 22, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 445329
Commit: b5a52ca5fec2b4656bc9530e3aa9da46333e9f97

aarch64-linux

✅ 4 packages built:
  • freecad
  • opencollada
  • python312Packages.ifcopenshell
  • python313Packages.ifcopenshell

Frontear
Frontear reviewed Sep 23, 2025
View reviewed changes
LordGrimmauld
LordGrimmauld approved these changes Sep 23, 2025
View reviewed changes
Copy link
Contributor

@LordGrimmauld LordGrimmauld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@LordGrimmauld LordGrimmauld added this pull request to the merge queue Sep 23, 2025
@LordGrimmauld
Copy link
Contributor

LordGrimmauld commented Sep 23, 2025

opencollada-blender is broken the same way, but that is tracking some fork and might be fine with just an update. I did not investigate that one yet.

Merged via the queue into NixOS:master with commit a8d0059 Sep 23, 2025
27 of 31 checks passed
@LordGrimmauld LordGrimmauld mentioned this pull request Sep 23, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LordGrimmauld LordGrimmauld LordGrimmauld approved these changes

+1 more reviewer

@Frontear Frontear Frontear left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@eetwas @grimmauld-bot @LordGrimmauld @Frontear