Skip to content

libLAS: fix build with cmake4#445202

Merged
imincik merged 1 commit intoNixOS:masterfrom
qbisi:libLAS
Sep 24, 2025
Merged

libLAS: fix build with cmake4#445202
imincik merged 1 commit intoNixOS:masterfrom
qbisi:libLAS

Conversation

@qbisi
Copy link
Contributor

@qbisi qbisi commented Sep 22, 2025

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. labels Sep 22, 2025
@qbisi
Copy link
Contributor Author

qbisi commented Sep 22, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 445202 -p libLAS
Commit: 30a47a44a52c0ef10ef7cc1eda16cc691886adc1 (subsequent changes)
Merge: c35fbfa6c747397e54080e126f7f19f62a5ed6a8

Logs: https://github.com/qbisi/nixpkgs-review-gha/actions/runs/17914236520


x86_64-linux

✅ 1 package built:
  • libLAS

aarch64-linux

✅ 1 package built:
  • libLAS

x86_64-darwin (sandbox = true)

✅ 1 package built:
  • libLAS

aarch64-darwin (sandbox = true)

✅ 1 package built:
  • libLAS

@qbisi qbisi marked this pull request as ready for review September 22, 2025 12:14
Copy link
Contributor

@nh2 nh2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me. Only request for 1 comment. Good to merge after.

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Sep 22, 2025
@qbisi qbisi force-pushed the libLAS branch 2 times, most recently from 3c9afc0 to 42c1a9c Compare September 22, 2025 14:12
@qbisi
Copy link
Contributor Author

qbisi commented Sep 22, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 445202 -p libLAS
Commit: 86ddf570fd2e732509631438018c3dee6e775e3c (subsequent changes)
Merge: 1347ace3af17c71af9818a5785e1c30bf58e6987

Logs: https://github.com/qbisi/nixpkgs-review-gha/actions/runs/17920227031


x86_64-linux

✅ 1 package built:
  • libLAS

aarch64-linux

✅ 1 package built:
  • libLAS

x86_64-darwin (sandbox = true)

✅ 1 package built:
  • libLAS

aarch64-darwin (sandbox = true)

✅ 1 package built:
  • libLAS

@qbisi qbisi mentioned this pull request Sep 23, 2025
13 tasks
Copy link
Contributor

@imincik imincik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now. Thank you @qbisi .

@imincik imincik added this pull request to the merge queue Sep 24, 2025
Merged via the queue into NixOS:master with commit 34ba0f1 Sep 24, 2025
29 of 31 checks passed
@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Sep 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants