Conversation
nixpkgs-ci
bot
added
10.rebuild-linux: 101-500
nix-owners
bot
requested review from
autra,
imincik,
l0b0,
nh2,
nialov,
sikmir and
willcohen
|
also need to patch liblas's findLASZIP since the header are installed in $out/include instead of $out/include/laszip see: libLAS/libLAS#230 |
LordGrimmauld
left a comment
LordGrimmauld
left a comment
There was a problem hiding this comment.
I was slightly worried. Building with autotools means the cmake files would not be installed. However, turns out cmake files were never installed to begin with. It'd be nice to have, that way there'd be less guessing about include paths. But alas, it is what it is, and in this case autotools build probably won't break much.
|
(oops, should have been comment, not request changes, sorry - checking this pr now) |
|
changes in libLAS have been moved to seperate pr #445202. |
LordGrimmauld
left a comment
LordGrimmauld
left a comment
There was a problem hiding this comment.
Okay this does actually break. When built with autotools, laszip-config ends up missing. There is also only an include path, no cmake or package config files.
I'd prefer a substituteInPlace to bump the cmake min version instead.
|
laszip_2 use the same upstream source as laszip and it will never get updated, the compatiblilty with cmake v4 or higher is unkonwn. |
|
It should be fine to just force cmake minimum version 3.10. Chances are they don't use anything that changed between 2.6 (or whatever current min version is) and 3.10 |
|
The version/source of laszip_2 is frozen. Does cmake v4 has long term backward compatilbilty with version 3.10, so we dont have to change the substitution when upgrading cmake. |
|
Or we can drop laszip_2 once libLAS build with laszip nixpkgs/pkgs/by-name/li/libLAS/package.nix Lines 64 to 70 in 554be64 |
|
laszip iirc also goes into vtk.
Yes, this is the plan. |
qbisi
changed the title
qbisi
changed the title
2 participants
laszip_2 not compatible with cmake4, hence build with autoreconfHook
ref: https://gitlab.archlinux.org/archlinux/packaging/packages/laszip2/-/blob/main/PKGBUILD?ref_type=heads
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.