{python3packages.py,}meshlab: 2023.12 -> 2025.07 + use system dependencies , and update dependencies#445078
Merged
jopejoe1 merged 26 commits intoNixOS:masterfrom Oct 28, 2025
Merged
{python3packages.py,}meshlab: 2023.12 -> 2025.07 + use system dependencies , and update dependencies#445078jopejoe1 merged 26 commits intoNixOS:masterfrom
jopejoe1 merged 26 commits intoNixOS:masterfrom
Conversation
Contributor
Author
|
7b28d0d to
0cf289a
Compare
pca006132
approved these changes
Sep 22, 2025
pkgs/by-name/me/meshlab/1617_cmake-use-system-dependencies-install-exports.patch
Show resolved
Hide resolved
Contributor
Author
|
part of #445447 |
13 tasks
yzx9
reviewed
Sep 24, 2025
pkgs/by-name/me/meshlab/1617_cmake-use-system-dependencies-install-exports.patch
Show resolved
Hide resolved
yzx9
reviewed
Sep 24, 2025
nim65s
commented
Sep 24, 2025
Contributor
|
yzx9
approved these changes
Sep 30, 2025
fix meshlab on darwin:
```
[ 47%] Building CXX object src/meshlabplugins/filter_cubization/CMakeFiles/filter_cubization.dir/filter_cubization_autogen/mocs_compilation.cpp.o
In file included from /tmp/nix-build-meshlab-2025.07.drv-0/source/build/src/meshlabplugins/filter_cubization/filter_cubization_autogen/mocs_compilation.cpp:2:
In file included from /tmp/nix-build-meshlab-2025.07.drv-0/source/build/src/meshlabplugins/filter_cubization/filter_cubization_autogen/EWIEGA46WW/moc_filter_cubization.cpp:10:
In file included from /tmp/nix-build-meshlab-2025.07.drv-0/source/build/src/meshlabplugins/filter_cubization/filter_cubization_autogen/EWIEGA46WW/../../../../../../src/meshlabplugins/filter_cubization/filter_cubization.h:28:
In file included from /tmp/nix-build-meshlab-2025.07.drv-0/source/src/common/../common/plugins/interfaces/filter_plugin.h:29:
In file included from /tmp/nix-build-meshlab-2025.07.drv-0/source/src/common/../common/plugins/interfaces/../../ml_document/mesh_document.h:27:
In file included from /tmp/nix-build-meshlab-2025.07.drv-0/source/src/common/../common/plugins/interfaces/../../ml_document/mesh_model.h:26:
In file included from /nix/store/18nlfi993h20y6dd1kfg8zm9gaglwygn-glew-2.2.0-dev/include/GL/glew.h:1217:
In file included from /nix/store/rhlyld20zdzdi5wghb4b12gw52s9whr9-apple-sdk-11.3/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/System/Library/Frameworks/OpenGL.framework/Headers/glu.h:9:
/nix/store/zchkzj4md6q4lq09iidcm4c8n7r22k46-libigl-2.6.0/include/igl/OpenGL/gl.h:23:10: fatal error: 'glad/glad.h' file not found
23 | #include <glad/glad.h>
| ^~~~~~~~~~~~~
```
Co-authored-by: Sandro <[email protected]>
- fix CMake exports - add missing library - update to llvm 19 Co-authored-by: Zexin Yuan <[email protected]>
Co-authored-by: Sandro <[email protected]>
Co-authored-by: Sandro <[email protected]>
Co-authored-by: jopejoe1 <[email protected]>
Somehow this was working before, but around 2025-10-23, something changed on master, and nixpkgs-review would stop working on NixOS#445078: ``` $ nix build -L github:NixOS/pull/445078/head#lib3mf.dev $ eza result-dev/include/ lib3mf/ $ nix build -L github:NixOS/pull/445078/merge#lib3mf.dev $ eza result-dev/include/ "result-dev/include/": No such file or directory (os error 2) ``` The headers are now installed in the build tree: ``` -- Installing: /nix/store/i7qd0hcky65i557fqjl5qq3xrp30hwhz-lib3mf-2.4.1/lib/lib3mf.so.2 -- Installing: /nix/store/i7qd0hcky65i557fqjl5qq3xrp30hwhz-lib3mf-2.4.1/lib/lib3mf.so -- Installing: /build/source/build/include/lib3mf/Bindings -- Installing: /build/source/build/include/lib3mf/Bindings/NodeJS -- Installing: /build/source/build/include/lib3mf/Bindings/NodeJS/lib3mf_nodeaddon.cc -- Installing: /build/source/build/include/lib3mf/Bindings/NodeJS/lib3mf_nodewrapper.cc ``` Maybe CMake 4.1.1 -> 4.1.2 changed something.
Contributor
Author
|
rebased to fix a new conflict in aliases.nix |
Member
|
Running one more rebuild if that one succeeds, I will merge this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #451139
Hi,
This PR update meshlab & python3Packages.pymeshlab from 2023.12 to 2025.07, among other things to fix build with CMake v4.
It also update their dependencies (levmar, lib3mf, tinygltf, vcg, corto, and nexus) and their packaging to use standard CMake exports (ref. cnr-isti-vclab/vcglib#248)
While here, meshlab-unstable is dropped, since it was older than 2025.07, cc. @pca006132
When I started to work on this, I did not see the work from #396295 (merged only 4 days ago), so I tried to merge this work with mine, but a few things might seem odd in the history. cc. @yzx9
I tested that by opening meshlab GUI and loading a mesh (only on linux) and trying a simple mesh decimation from python (linux & darwin):
And, yes,
base_link2.STLtakes less disk space thanbase_link.STL(a random file from example-robot-data)Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.