Merged
Conversation
Should let us drop the Darwin hack, and not have to apply it on other platfomrs, like musl, too. I used Nixpkgs' gnulib source because it works, but if it stops working in future we could use fetchgit to get the gnulib submodule. Fixes: 90805a4 ("gss: use autoreconfHook") Closes: NixOS#436189
alyssais
force-pushed
the
gss-autoreconf
branch
from
5340d7f to
a390262
Compare
nixpkgs-ci
bot
added
10.rebuild-linux: 11-100
yuyuyureka
approved these changes
Sep 21, 2025
Contributor
yuyuyureka
left a comment
yuyuyureka
left a comment
There was a problem hiding this comment.
built on aarch64-darwin
LGTM
wegank
approved these changes
Sep 21, 2025
nixpkgs-ci
bot
added
the
12.approvals: 2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should let us drop the Darwin hack, and not have to apply it on other platfomrs, like musl, too.
I used Nixpkgs' gnulib source because it works, but if it stops working in future we could use fetchgit to get the gnulib submodule.
Closes: #436189
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.