tbb: tbb_2020 -> tbb_2022; tbb_2020: drop; onetbb: rename from tbb_2022#442977
tbb: tbb_2020 -> tbb_2022; tbb_2020: drop; onetbb: rename from tbb_2022#442977emilazy merged 12 commits intoNixOS:stagingfrom
tbb_2022#442977Conversation
nixpkgs-ci
bot
added
10.rebuild-linux: 501+
|
cc @silvanshade @thoughtpolice @hesiod again |
|
ACK on embree2 and embreex. It's sad to see it go considering my PhD data procesing pipeline is greatly accelerated by it, but that thing is stuck on python310 anyway. Dropping them should not affect the affordance of trimesh, only speed. LGTM |
emilazy
force-pushed
the
push-zxvnryortpqx
branch
from
4dfd857 to
cf4b52c
Compare
|
Good luck with your PhD! For what it’s worth, Embree 2 can be built with an internal tasking library; I don’t know how performance would compare or if any functionality would suffer, but that would presumably at least cut the dependency on Rebased for conflicts, also. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
nixpkgs-ci
bot
added
the
2.status: merge conflict
This version is maintained, works with LLVM 21, and does not seem to result in any regressions to immediate reverse dependencies on `aarch64-linux` any more other than packages already fixed or dropped.
This is the upstream name and there doesn’t seem to be a strong reason to keep around multiple versions now.
emilazy
force-pushed
the
push-zxvnryortpqx
branch
from
cf4b52c to
66e1a70
Compare
nixpkgs-ci
bot
removed
the
2.status: merge conflict
Hey that's pretty neat! However locking it to some old version if nixpkgs is fine for now. I'm doing the final experiments and writeup anyway. :) |
|
@emilazy This looks good. Thanks for working on it. Would you consider maybe adding yourself as a maintainer? |
nixpkgs-ci
bot
added
12.approvals: 1
|
I probably wouldn’t be a great choice for it; this is ultimately drive‐by work to fix things up for the upcoming LLVM 21 bump, I don’t use the package directly :) I try to leave things simpler than when I started, though! If there’s any other particularly mysterious Darwin problems in future I can try to take a look… |
|
Glad to see only "one" tbb. |
tbb_* was renamed to onetbb. See NixOS/nixpkgs#442977. tbb_2021_11, which was used in rosdep before has been replaced by tbb_2021 earlier in NixOS/nixpkgs#402480. Signed-off-by: Michal Sojka <[email protected]>
tbb_* was renamed to onetbb. See NixOS/nixpkgs#442977. tbb_2021_11, which was used in rosdep before has been replaced by tbb_2021 earlier in NixOS/nixpkgs#402480. Signed-off-by: Michal Sojka <[email protected]>
In recent nixpkgs, all tbb_* versions were renamed to a single onetbb package: NixOS/nixpkgs#442977. This change was reflected in rosdep (ros/rosdistro#48172) and merged pretty quickly, definitely faster than we'll be able to switch master branch to the new nixpkgs version (we need to solve all Qt5 problems before). Therefore, we add this alias so that people using recent rosdep (e.g. via ros2nix) with the master branch do not end up with broken derivations.
In recent nixpkgs, all tbb_* versions were renamed to a single onetbb package: NixOS/nixpkgs#442977. This change was reflected in rosdep (ros/rosdistro#48172) and merged pretty quickly, definitely faster than we'll be able to switch master branch to the new nixpkgs version (we need to solve all Qt5 problems before). Therefore, we add this alias so that people using recent rosdep (e.g. via ros2nix) with the master branch do not end up with broken derivations.
In recent nixpkgs, all tbb_* versions were renamed to a single onetbb package: NixOS/nixpkgs#442977. This change was reflected in rosdep (ros/rosdistro#48172) and merged pretty quickly, definitely faster than we'll be able to switch master branch to the new nixpkgs version (we need to solve all Qt5 problems before). Therefore, we add this alias so that people using recent rosdep (e.g. via ros2nix) with the master branch do not end up with broken derivations.
4 participants
This version is maintained, works with LLVM 21, and does not seem to result in any regressions to immediate reverse dependencies on
aarch64-linuxany more other than packages already fixed or dropped.I successfully built:
bowtie2brickstorecloudcomparecurveasyeffectselmerfemembreeenvisionf3dikosispcmeshlabmeshlab-unstablemirtkopencv4openimagedenoiseopenpglopenturnsopenvdbpagmo2potreeconverterpython313Packages.cgalpython313Packages.gudhipython313Packages.openusdpython313Packages.pymeshlabsysdigtracyviskoresvcmivtkcc @pbsds @Hodapp87 for
python313Packages.embreexandembree2drops. There is a WIP pull request to update the former to Embree 4, but it seems stalled.Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.