tbb_2022: 2022.1.0 -> 2022.2.0, clean up, fix macOS; tbb_2021: drop#442554
tbb_2022: 2022.1.0 -> 2022.2.0, clean up, fix macOS; tbb_2021: drop#442554emilazy merged 10 commits intoNixOS:masterfrom
Conversation
One patch landed upstream. Diff: uxlfoundation/oneTBB@v2022.1.0...v2022.2.0
716e381 to
6f72a5c
Compare
|
Will run a full |
|
Not sure why it didn’t cc maintainers. |
szlend
left a comment
There was a problem hiding this comment.
The TBB crashes on macOS have been bugging me for a while now. Glad you figured it out!
|
This looks really nice. Thanks for investigating and fixing the macOS issues. |
Mic92
left a comment
There was a problem hiding this comment.
Fine with me if nix builds fine with it.
|
|
Regressions vs. It’s all Hyprland stuff that looks unrelated to me. Still waiting on full results for |
|
|
I omitted |
Unmerged PRs are not stable fetch targets.
CMake already enables this by default.
Everything that built with `tbb_2021` builds successfully with `tbb_2022` on `aarch64-linux`, and `tbb_2022` no longer causes crashes on Darwin.
`tbb_2022` no longer causes crashes.
6f72a5c to
1e05afe
Compare
|
|
There was one regression: Which I have now fixed, by disabling one TBB test on static. This should be ready to go. |
I diagnosed and sent a PR for the
tbb_2022macOS issue upstream. Everything that builds withtbb_2021builds withtbb_2022onaarch64-linux, so let’s do some clean‐up, especially astbb_2021doesn’t build out of the box with LLVM 21.cc @szlend for #407674
cc @Mic92 for #393048
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.