You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Bump version to 0.57 and undo no longer needed patch from #428579 since YosysHQ/yosys#5182 is included in 0.57. Also add a comment for when another patch could be removed
CMake Deprecation Warning at src/libs/lua/CMakeLists.txt:1 (CMAKE_MINIMUM_REQUIRED):
Compatibility with CMake < 3.10 will be removed from a future version of
CMake.
Update the VERSION argument value. Or, use the ... syntax
to tell CMake that the project requires at least but has been updated
to work with policies introduced by or earlier.
CMake Deprecation Warning at src/libs/luabind-deboostified/CMakeLists.txt:6 (cmake_minimum_required):
Compatibility with CMake < 3.10 will be removed from a future version of
CMake.
Update the VERSION argument value. Or, use the ... syntax
to tell CMake that the project requires at least but has been updated
to work with policies introduced by or earlier.
/build/source/src/mods/yosys_ast/synlig_ilang.cc: In member function 'virtual void Synlig::WriteIlangAlias::execute(std::vector >, Yosys::RTLIL::Design*)':
/build/source/src/mods/yosys_ast/synlig_ilang.cc:18:27: warning: comparison of integer expressions of different signedness: 'int' and 'std::vector >::size_type' {aka 'long unsigned int'} [8;;https://gcc.gnu.org/onlinedocs/gcc-14.3.0/gcc/Warning-Options.html#index-Wno-sign-compare�-Wsign-compare8;;�]
18 | for (int i = 1; i < args.size(); i++)
| ~~^~~~~~~~~~~~~
/build/source/src/mods/yosys_ast/synlig_edif.cc: In lambda function:
/build/source/src/mods/yosys_ast/synlig_edif.cc:328:38: warning: comparison of integer expressions of different signedness: 'size_t' {aka 'long unsigned int'} and 'int' [8;;https://gcc.gnu.org/onlinedocs/gcc-14.3.0/gcc/Warning-Options.html#index-Wno-sign-compare�-Wsign-compare8;;�]
328 | for (size_t i = 0; i < val.size(); i += 4) {
| ~~^~~~~~~~~~~~
/build/source/src/mods/yosys_ast/synlig_edif.cc:330:31: warning: comparison of integer expressions of different signedness: 'size_t' {aka 'long unsigned int'} and 'int' [8;;https://gcc.gnu.org/onlinedocs/gcc-14.3.0/gcc/Warning-Options.html#index-Wno-sign-compare�-Wsign-compare8;;�]
330 | if (i + 0 < val.size() && val.at(i + 0) == RTLIL::State::S1)
| ~~~~~~^~~~~~~~~~~~
/build/source/src/mods/yosys_ast/synlig_edif.cc:332:31: warning: comparison of integer expressions of different signedness: 'size_t' {aka 'long unsigned int'} and 'int' [8;;https://gcc.gnu.org/onlinedocs/gcc-14.3.0/gcc/Warning-Options.html#index-Wno-sign-compare�-Wsign-compare8;;�]
332 | if (i + 1 < val.size() && val.at(i + 1) == RTLIL::State::S1)
| ~~~~~~^~~~~~~~~~~~
/build/source/src/mods/yosys_ast/synlig_edif.cc:334:31: warning: comparison of integer expressions of different signedness: 'size_t' {aka 'long unsigned int'} and 'int' [8;;https://gcc.gnu.org/onlinedocs/gcc-14.3.0/gcc/Warning-Options.html#index-Wno-sign-compare�-Wsign-compare8;;�]
334 | if (i + 2 < val.size() && val.at(i + 2) == RTLIL::State::S1)
| ~~~~~~^~~~~~~~~~~~
/build/source/src/mods/yosys_ast/synlig_edif.cc:336:31: warning: comparison of integer expressions of different signedness: 'size_t' {aka 'long unsigned int'} and 'int' [8;;https://gcc.gnu.org/onlinedocs/gcc-14.3.0/gcc/Warning-Options.html#index-Wno-sign-compare�-Wsign-compare8;;�]
336 | if (i + 3 < val.size() && val.at(i + 3) == RTLIL::State::S1)
| ~~~~~~^~~~~~~~~~~~
I can confirm that the package builds and works on x86_64-linux as expected, but it seems like this bump generates a bunch of regressions in packages dependent on yosys :/
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump version to 0.57 and undo no longer needed patch from #428579 since YosysHQ/yosys#5182 is included in 0.57. Also add a comment for when another patch could be removed
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.
cc @tsandrini