ghcWithPackages: expose targetPrefix; tests.haskell.ghcWithPackages: verify -fllvm works with useLLVM#441471
Merged
sternenseemann merged 3 commits intoNixOS:masterfrom Sep 11, 2025
Conversation
Note that this test also succeeds in pkgsCross though using a stdenv with cc is crucial, since its setup hooks are required for -lgmp to work. Maybe this is something we should look at for GHC again, maybe we can add extra entries to the package db, so it passes the necessary -L flags by itself?
Obviously, we can't run GHCi of a cross-compiler, but respecting targetPrefix
will give a more helpful error message:
<command line>: not built for interactive use
13 tasks
nixpkgs-ci
bot
added
10.rebuild-linux: 1-10
emilazy
approved these changes
Sep 10, 2025
Member
emilazy
left a comment
emilazy
left a comment
There was a problem hiding this comment.
Haven’t tested; code looks fine.
nixpkgs-ci
bot
added
the
12.approvals: 1
Member
Author
|
Why does the merge queue think No PR failures has not reported yet while having a green tick on the latest commit?! |
Contributor
|
Because that's the "No PR failures" run for the PR workflow. The Merge Queue runs it again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.