rocmPackages.llvm: bug for bug compatible overrideScope usage #440697
Closed
LunNova wants to merge 3 commits intoNixOS:masterfrom
Closed
rocmPackages.llvm: bug for bug compatible overrideScope usage #440697LunNova wants to merge 3 commits intoNixOS:masterfrom
LunNova wants to merge 3 commits intoNixOS:masterfrom
Conversation
005ff2f to
d0fb961
Compare
Member
Author
|
13 tasks
efc3a7b to
1071572
Compare
1071572 to
17f2ecb
Compare
16fd4fa to
76144e6
Compare
Uses new overrideScope feature to override base LLVM packages without risking leaking incorrect non-overridden packages from the base LLVM version. To achieve no rebuilds or new attrs: - Explicit list of packages to expose in an inherit instead of the entire scope - Noting where workarounds for lack of overrideScope should be removed in a followup such as re-attaching a replaceVars patch or disabling separate tblgen package, but are kept for now to avoid a rebuild - Override compiler-rt to continue incorrectly using the base LLVM's libllvm. This was an accident in the prior version, overrideScope tries to help us by correcting this mistake. To avoid a large formatting diff a small helper has been introduced that allows an overrideScope call with a single arg, convincing nixfmt not to indent the scope body further.
76144e6 to
47393c7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just want CI to run and hopefully prove no rebuilds, intended to provide an idea of an approach for another PR.