{crystal_1_14,crystal_1_15,crystal_1_16,crystal_1_17}: bump LLVM; crystal_1_11: drop#439928
Merged
emilazy merged 3 commits intoNixOS:masterfrom Sep 5, 2025
Merged
{crystal_1_14,crystal_1_15,crystal_1_16,crystal_1_17}: bump LLVM; crystal_1_11: drop#439928emilazy merged 3 commits intoNixOS:masterfrom
emilazy merged 3 commits intoNixOS:masterfrom
Conversation
nixpkgs-ci
bot
added
10.rebuild-linux: 11-100
nix-owners
bot
requested review from
davy-tw,
donovanglover,
manveru and
peterhoeg
Member
|
It seems that there is a viable way to fix AHK_X11 in the upstream (phil294/AHK_X11#89 (comment)). I'll try to see whether I can open a PR in the upstream for this. |
Member
|
Also #426591 wasn't even reviewed, but let's leave it open for now. |
Member
|
I opened phil294/AHK_X11#112. Before it is merged, could you please use |
emilazy
force-pushed
the
push-uzmnzsssmxsv
branch
from
bf533b8 to
32b36d9
Compare
Member
Author
|
Wow, thank you for the very quick patch! I have cherry‐picked your update PR into this one and added the patch; let me know what you think. I verified the build on |
Member
|
Member
Author
|
Not sure what’s going on with the |
UlyssesZh
reviewed
Sep 4, 2025
Comment on lines
-172
to
-175
Member
There was a problem hiding this comment.
Should the whole if clause be removed? It makes more sense to me if the export line is kept here.
Member
Author
There was a problem hiding this comment.
Good catch, thank you! Fixed.
emilazy
force-pushed
the
push-uzmnzsssmxsv
branch
from
32b36d9 to
e30380b
Compare
See: * <https://github.com/crystal-lang/crystal/blob/1.14.1/src/llvm/ext/llvm-versions.txt> * <https://github.com/crystal-lang/crystal/blob/1.15.1/src/llvm/ext/llvm-versions.txt> * <https://github.com/crystal-lang/crystal/blob/1.16.3/src/llvm/ext/llvm-versions.txt> * <https://github.com/crystal-lang/crystal/blob/1.17.1/src/llvm/ext/llvm-versions.txt>
Member
|
AHK_X11 upstream merged the PR and made some follow-up commits. Could you update it and remove the patch? |
13 tasks
Co-authored-by: Ulysses Zhan <[email protected]>
LLVM 15 is being removed for the 25.11 release.
emilazy
force-pushed
the
push-uzmnzsssmxsv
branch
from
e30380b to
48c2a4e
Compare
Member
Author
|
Done, though I see upstream still seems to be seeing issues, going by phil294/AHK_X11#89 (comment); are you able to reproduce that? |
Member
|
The basic functionalities still work. The issue comment says that the installer cannot run, but I patched to remove the installer in |
Member
Author
|
Good enough for me :) I will leave this for a few days for other reviewers to take a look at. |
kachick
approved these changes
Sep 5, 2025
Member
kachick
left a comment
kachick
left a comment
There was a problem hiding this comment.
LGTM, though there are several failures on GitHub Actions. 👍
NOTE:
mint package seems unstable.
For example, nixpkgs-review for revision 32b36d9477f4b9064becab9c50f255658a2eb5c3 failed on x86_64-linux, and the latest result for 48c2a4e only passed on that x86_64-linux.
Additionally, I couldn't get a full set of results on the ubuntu-24.04-arm GitHub Actions runner, likely due to a lack of resources.
nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 439928
Commit: 48c2a4e44078ae665aec1eddc0b1f4e562c0e7d1
x86_64-linux
✅ 31 packages built:
- ahk_x11
- ameba
- ameba-ls
- amqpcat
- blahaj
- collision
- crystal (crystal_1_16)
- crystal.bin (crystal_1_16.bin)
- crystal.lib (crystal_1_16.lib)
- crystal2nix
- crystal_1_14
- crystal_1_14.bin
- crystal_1_14.lib
- crystal_1_15
- crystal_1_15.bin
- crystal_1_15.lib
- crystal_1_17
- crystal_1_17.bin
- crystal_1_17.lib
- crystalline
- gi-crystal
- icr
- invidious
- kakoune-cr
- lucky-cli
- mint
- oq
- rtfm
- shards
- thicket
- tmuxPlugins.fingers
x86_64-darwin
❌ 1 package failed to build:
- mint
✅ 27 packages built:
- ameba
- ameba-ls
- amqpcat
- blahaj
- crystal (crystal_1_16)
- crystal.bin (crystal_1_16.bin)
- crystal.lib (crystal_1_16.lib)
- crystal2nix
- crystal_1_14
- crystal_1_14.bin
- crystal_1_14.lib
- crystal_1_15
- crystal_1_15.bin
- crystal_1_15.lib
- crystal_1_17
- crystal_1_17.bin
- crystal_1_17.lib
- crystalline
- gi-crystal
- icr
- invidious
- kakoune-cr
- lucky-cli
- oq
- shards
- thicket
- tmuxPlugins.fingers
Error logs: `x86_64-darwin`
mint
[0x10a418896] *GC::realloc<Pointer(UInt8), Int32>:Pointer(UInt8) +38 in /nix/var/nix/builds/nix-build-mint-0.24.1.drv-3546-4236015163/source/.crystal/crystal-run-spec.tmp [0x10a4141ee] *String::Builder#resize_to_capacity<Int32>:Pointer(UInt8) +30 in /nix/var/nix/builds/nix-build-mint-0.24.1.drv-3546-4236015163/source/.crystal/crystal-run-spec.tmp [0x10a4143c0] *String::Builder#to_s:String +128 in /nix/var/nix/builds/nix-build-mint-0.24.1.drv-3546-4236015163/source/.crystal/crystal-run-spec.tmp [0x10a40386e] *String::interpolation<Colorize::Object(String), Colorize::Object(String)>:String +1150 in /nix/var/nix/builds/nix-build-mint-0.24.1.drv-3546-4236015163/source/.crystal/crystal-run-spec.tmp [0x10ad1c79d] *Mint::TerminalSnippet@Mint::TerminalSnippet::render<String, String, Int64, Int64, Int32, Int32>:String +7869 in /nix/var/nix/builds/nix-build-mint-0.24.1.drv-3546-4236015163/source/.crystal/crystal-run-spec.tmp [0x10ad1a8d0] *Mint::TerminalSnippet@Mint::TerminalSnippet::render:filename:input:from:to:width<String, String, Int64, Int64, Int32>:String +64 in /nix/var/nix/builds/nix-build-mint-0.24.1.drv-3546-4236015163/source/.crystal/crystal-run-spec.tmp [0x10ad1a619] *Mint::Render::Terminal#snippet<Mint::Error::SnippetData>:Nil +89 in /nix/var/nix/builds/nix-build-mint-0.24.1.drv-3546-4236015163/source/.crystal/crystal-run-spec.tmp [0x10a50b4cd] *Mint::Error#to_terminal:IO+ +477 in /nix/var/nix/builds/nix-build-mint-0.24.1.drv-3546-4236015163/source/.crystal/crystal-run-spec.tmp [0x10a39b165] ~procProc(Nil)@spec/errors_spec.cr:8 +261 in /nix/var/nix/builds/nix-build-mint-0.24.1.drv-3546-4236015163/source/.crystal/crystal-run-spec.tmp [0x10a5c0ff6] *Spec::Example#internal_run<Time::Span, Proc(Nil)>:(Array(Spec::Result) | Nil) +246 in /nix/var/nix/builds/nix-build-mint-0.24.1.drv-3546-4236015163/source/.crystal/crystal-run-spec.tmp [0x10a5c0edf] *Spec::Example#run:Nil +1839 in /nix/var/nix/builds/nix-build-mint-0.24.1.drv-3546-4236015163/source/.crystal/crystal-run-spec.tmp [0x10a55d2ec] *Spec::RootContext@Spec::Context#internal_run:Nil +124 in /nix/var/nix/builds/nix-build-mint-0.24.1.drv-3546-4236015163/source/.crystal/crystal-run-spec.tmp [0x10a55d26a] *Spec::RootContext#run:Nil +26 in /nix/var/nix/builds/nix-build-mint-0.24.1.drv-3546-4236015163/source/.crystal/crystal-run-spec.tmp [0x10a52ffe4] *Spec::CLI#execute_examples:Nil +52 in /nix/var/nix/builds/nix-build-mint-0.24.1.drv-3546-4236015163/source/.crystal/crystal-run-spec.tmp [0x10a34e52b] ~procProc(Int32, (Exception | Nil), Nil)@/nix/store/ci82c9xx3cm54kggnd7qdn7vy8b36s87-crystal-1.16.3-lib/crystal/spec/dsl.cr:212 +91 in /nix/var/nix/builds/nix-build-mint-0.24.1.drv-3546-4236015163/source/.crystal/crystal-run-spec.tmp [0x10a4fefbc] *Crystal::AtExitHandlers::run<Int32, (Exception+ | Nil)>:Int32 +492 in /nix/var/nix/builds/nix-build-mint-0.24.1.drv-3546-4236015163/source/.crystal/crystal-run-spec.tmp [0x10a4a4761] *Crystal::exit<Int32, (Exception+ | Nil)>:Int32 +33 in /nix/var/nix/builds/nix-build-mint-0.24.1.drv-3546-4236015163/source/.crystal/crystal-run-spec.tmp [0x10a4a46c6] *Crystal::main<Int32, Pointer(Pointer(UInt8))>:Int32 +102 in /nix/var/nix/builds/nix-build-mint-0.24.1.drv-3546-4236015163/source/.crystal/crystal-run-spec.tmp [0x10a2fd84b] main +27 in /nix/var/nix/builds/nix-build-mint-0.24.1.drv-3546-4236015163/source/.crystal/crystal-run-spec.tmp [0x7ff80e1bd418] start +1896 in /usr/lib/dyld
aarch64-darwin
❌ 1 package failed to build:
- mint
✅ 27 packages built:
- ameba
- ameba-ls
- amqpcat
- blahaj
- crystal (crystal_1_16)
- crystal.bin (crystal_1_16.bin)
- crystal.lib (crystal_1_16.lib)
- crystal2nix
- crystal_1_14
- crystal_1_14.bin
- crystal_1_14.lib
- crystal_1_15
- crystal_1_15.bin
- crystal_1_15.lib
- crystal_1_17
- crystal_1_17.bin
- crystal_1_17.lib
- crystalline
- gi-crystal
- icr
- invidious
- kakoune-cr
- lucky-cli
- oq
- shards
- thicket
- tmuxPlugins.fingers
Error logs: `aarch64-darwin`
mint
[0x104197908] *Exception::CallStack::print_backtrace:Nil +112 in /nix/var/nix/builds/nix-build-mint-0.24.1.drv-2676-2506379928/source/.crystal/crystal-run-spec.tmp [0x1041113a0] ~procProc(Int32, Pointer(LibC::SiginfoT), Pointer(Void), Nil)@/nix/store/jrq978gm4r57ypd8mcz47x3d11km1h7c-crystal-1.16.3-lib/crystal/crystal/system/unix/signal.cr:173 +276 in /nix/var/nix/builds/nix-build-mint-0.24.1.drv-2676-2506379928/source/.crystal/crystal-run-spec.tmp [0x19c910624] _sigtramp +56 in /usr/lib/system/libsystem_platform.dylib [0x1041e5e10] *GC::malloc_atomic<UInt64>:Pointer(Void) +84 in /nix/var/nix/builds/nix-build-mint-0.24.1.drv-2676-2506379928/source/.crystal/crystal-run-spec.tmp (2 times) [0x1041e5db4] *GC::malloc_atomic<UInt32>:Pointer(Void) +16 in /nix/var/nix/builds/nix-build-mint-0.24.1.drv-2676-2506379928/source/.crystal/crystal-run-spec.tmp [0x1041e050c] *String::Builder#initialize<Int32>:Bool +188 in /nix/var/nix/builds/nix-build-mint-0.24.1.drv-2676-2506379928/source/.crystal/crystal-run-spec.tmp [0x1041e0440] *String::Builder::new<Int32>:String::Builder +96 in /nix/var/nix/builds/nix-build-mint-0.24.1.drv-2676-2506379928/source/.crystal/crystal-run-spec.tmp [0x1041c9170] *String#gsub<Regex, String>:String +1756 in /nix/var/nix/builds/nix-build-mint-0.24.1.drv-2676-2506379928/source/.crystal/crystal-run-spec.tmp [0x1041ca680] *String#uncolorize:String +44 in /nix/var/nix/builds/nix-build-mint-0.24.1.drv-2676-2506379928/source/.crystal/crystal-run-spec.tmp [0x104173ed0] ~procProc(Nil)@spec/errors_spec.cr:8 +380 in /nix/var/nix/builds/nix-build-mint-0.24.1.drv-2676-2506379928/source/.crystal/crystal-run-spec.tmp [0x10437e358] *Spec::Example#internal_run<Time::Span, Proc(Nil)>:(Array(Spec::Result) | Nil) +228 in /nix/var/nix/builds/nix-build-mint-0.24.1.drv-2676-2506379928/source/.crystal/crystal-run-spec.tmp [0x10437e248] *Spec::Example#run:Nil +1932 in /nix/var/nix/builds/nix-build-mint-0.24.1.drv-2676-2506379928/source/.crystal/crystal-run-spec.tmp [0x104319d8c] *Spec::RootContext@Spec::Context#internal_run:Nil +152 in /nix/var/nix/builds/nix-build-mint-0.24.1.drv-2676-2506379928/source/.crystal/crystal-run-spec.tmp [0x104319ce8] *Spec::RootContext#run:Nil +28 in /nix/var/nix/builds/nix-build-mint-0.24.1.drv-2676-2506379928/source/.crystal/crystal-run-spec.tmp [0x1042edc00] *Spec::CLI#execute_examples:Nil +48 in /nix/var/nix/builds/nix-build-mint-0.24.1.drv-2676-2506379928/source/.crystal/crystal-run-spec.tmp [0x1041142a4] ~procProc(Int32, (Exception | Nil), Nil)@/nix/store/jrq978gm4r57ypd8mcz47x3d11km1h7c-crystal-1.16.3-lib/crystal/spec/dsl.cr:212 +108 in /nix/var/nix/builds/nix-build-mint-0.24.1.drv-2676-2506379928/source/.crystal/crystal-run-spec.tmp [0x1042bdf60] *Crystal::AtExitHandlers::run<Int32, (Exception+ | Nil)>:Int32 +476 in /nix/var/nix/builds/nix-build-mint-0.24.1.drv-2676-2506379928/source/.crystal/crystal-run-spec.tmp [0x104267a14] *Crystal::exit<Int32, (Exception+ | Nil)>:Int32 +40 in /nix/var/nix/builds/nix-build-mint-0.24.1.drv-2676-2506379928/source/.crystal/crystal-run-spec.tmp [0x104267960] *Crystal::main<Int32, Pointer(Pointer(UInt8))>:Int32 +112 in /nix/var/nix/builds/nix-build-mint-0.24.1.drv-2676-2506379928/source/.crystal/crystal-run-spec.tmp [0x1040adf20] main +32 in /nix/var/nix/builds/nix-build-mint-0.24.1.drv-2676-2506379928/source/.crystal/crystal-run-spec.tmp
nixpkgs-ci
bot
added
the
12.approvals: 1
Member
Author
|
Yeah, sounds like |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following up on #437526 (comment) for the bumps.
LLVM 15 is being removed for the 25.11 release.
ahk_x11is the only casualty here; hopefully the issues with supported Crystal versions can be worked out, or in the worst case the changes for newer LLVM support from later versions of Crystal could be backported to the 1.11 codebase?nixpkgs-reviewresultGenerated using
nixpkgs-review.Command:
nixpkgs-reviewCommit:
c0a8ca9803645de3fd491c8f3ea00513870e87b7x86_64-linux⏩ 1 package marked as broken and skipped:
✅ 30 packages built:
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.