cling: 1.0 -> 1.2-unstable-2025-09-01#439740
Closed
emilazy wants to merge 1 commit intoNixOS:masterfrom
Closed
Conversation
Member
Author
|
Ah, yes, and something would need doing about |
Contributor
|
Oh wow, very good timing. I've got Cling working fine and I'm working on |
Contributor
|
Here you go: #439741 |
1 task
Member
Author
|
Closing as #439741 is merged; hopefully the work here can still be useful in the future if someone wants to pick it up. |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@thomasjm I saw you were working on updating Cling in Nixpkgs in root-project/cling#556. I’ve also been poking at the package in preparation for the removal of LLVM 12–17 in Nixpkgs 25.11. I didn’t manage to get it fully working yet, but I thought I’d put up what I have so far for you to look at.
I’ve reused our existing LLVM build infrastructure, and was hoping to replace the existing wrapper with our normal
cc-wrapperlogic, but there is some weirdness around include paths – I’ve tried to bypass Cling’s somewhat dodgy logic to infer include paths itself, but that produced strange results where it would be unable to find any include directories other than the most recently‐added one when parsing an internal#include <new>expression, and with-noruntimethe include paths it searches seemed to change from the first line it processes and all subsequent lines.Of course, just a simple bump to a version that doesn’t pull in the old LLVM would be sufficient, so those issues may not be a blocker if the previous wrapper still works fine. I’d be happy to review your own work – bumping to the latest Git commit like this, or backporting the relevant patch to the stable release, per your preference – if you want to put up your own PR. But I thought it would be good to share this now.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.