linuxPackages.evdi: Fix flags#438688
Merged
alyssais merged 1 commit intoNixOS:masterfrom Aug 31, 2025
Merged
Conversation
Since NixOS#402198 kernel modules are no longer built with wrapped compilers. Firstly, NIX_CFLAGS_COMPILE is no longer effective, so we change that to CFLAGS, which is used in the Makefile for evdi. Secondly, we still need to use the wrapped compiler for userspace stuff, so separate that out in postBuild. Fixes NixOS#437311
This was referenced Aug 30, 2025
nixpkgs-ci
bot
added
10.rebuild-linux: 11-100
|
This fixes it for me on a macbook air 2014 with kensington hub. @dramforever thanks for working on this. |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
alyssais
approved these changes
Aug 31, 2025
| postBuild = '' | ||
| # Don't use makeFlags for userspace stuff | ||
| make library pyevdi | ||
| ''; |
Member
There was a problem hiding this comment.
I wonder if this would make sense to be in a separate package, like with ZFS…
| env.NIX_CFLAGS_COMPILE = toString [ | ||
| env.CFLAGS = toString [ | ||
| "-Wno-error" | ||
| "-Wno-error=discarded-qualifiers" # for Linux 4.19 compatibility |
Member
There was a problem hiding this comment.
We don't have Linux 4.19 any more, so hopefully would be possible to clean these up?
Contributor
Author
There was a problem hiding this comment.
These are for 4.19 plus. The kernel module is filled with const mismatches and signedness mismatches like these.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #402198 kernel modules are no longer built with wrapped compilers.
Firstly, NIX_CFLAGS_COMPILE is no longer effective, so we change that to CFLAGS, which is used in the Makefile for evdi.
Secondly, we still need to use the wrapped compiler for userspace stuff, so separate that out in postBuild.
Fixes #437311
Note: I do not have DisplayLink hardware. I have only inspected the build result. Please test.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.