rocmPackages.rocminfo: don't propagate python3#438399
Merged
GaetanLepage merged 6 commits intoNixOS:masterfrom Sep 3, 2025
Merged
rocmPackages.rocminfo: don't propagate python3#438399GaetanLepage merged 6 commits intoNixOS:masterfrom
GaetanLepage merged 6 commits intoNixOS:masterfrom
Conversation
13 tasks
nixpkgs-ci
bot
added
10.rebuild-linux: 11-100
LunNova
force-pushed
the
lunnova/fix-rocminfo-python-path-leak
branch
from
29901b4 to
592e1c8
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
LunNova
force-pushed
the
lunnova/fix-rocminfo-python-path-leak
branch
from
592e1c8 to
137eba8
Compare
LunNova
force-pushed
the
lunnova/fix-rocminfo-python-path-leak
branch
from
137eba8 to
9248633
Compare
nixpkgs-ci
bot
added
6.topic: python
This comment was marked as outdated.
This comment was marked as outdated.
LunNova
force-pushed
the
lunnova/fix-rocminfo-python-path-leak
branch
from
9248633 to
3841337
Compare
Causes incorrect python version to leak into deps of rocminfo
LunNova
force-pushed
the
lunnova/fix-rocminfo-python-path-leak
branch
from
d6b5281 to
20afe0f
Compare
This comment was marked as outdated.
This comment was marked as outdated.
nix-owners
bot
requested review from
Flakebi,
GZGavinZhao,
GaetanLepage,
lovesegfault,
mksafavi,
mschwaig,
teh,
thoughtpolice and
tscholak
nixpkgs-ci
bot
added
12.approvals: 1
Flakebi
approved these changes
Sep 1, 2025
nixpkgs-ci
bot
added
12.approvals: 2
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
Member
Author
|
Asked in https://matrix.to/#/#infra:nixos.org, @mweinelt says it should be ok to go via master. |
This comment was marked as resolved.
This comment was marked as resolved.
18 tasks
Member
|
@ofborg eval |
Contributor
|
Can you re-run |
Member
Author
|
GaetanLepage
approved these changes
Sep 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes incorrect python version leaking into deps of rocminfo / clr, potentially causing confusing errors about python packages not being found.
needs further iterations before I can mark ready for review; I expect some parts of the rocm package set are inadvertently relying onSorted now!clr->rocminfoproviding a python3.Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.