Skip to content

nixos/opensnitch: various fixes#438316

Merged
LordGrimmauld merged 6 commits intoNixOS:masterfrom
LordGrimmauld:opensnitch-fixes-full
Sep 9, 2025
Merged

nixos/opensnitch: various fixes#438316
LordGrimmauld merged 6 commits intoNixOS:masterfrom
LordGrimmauld:opensnitch-fixes-full

Conversation

@LordGrimmauld
Copy link
Contributor

@LordGrimmauld LordGrimmauld commented Aug 29, 2025

fixes #419093

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@LordGrimmauld LordGrimmauld mentioned this pull request Aug 29, 2025
Closed
@LordGrimmauld
Copy link
Contributor Author

LordGrimmauld commented Aug 29, 2025

I'll have a proper look at fixing the IFD in the opensnitch module after this lands, this is currently just purely bug fixes without changing the behavior.

@LordGrimmauld LordGrimmauld force-pushed the opensnitch-fixes-full branch from bcf75fd to 584d4e4 Compare August 29, 2025 16:50
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Aug 29, 2025
@LordGrimmauld LordGrimmauld requested a review from onny August 30, 2025 07:26
@nixpkgs-ci nixpkgs-ci bot removed the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Aug 30, 2025
SuperSandro2000
SuperSandro2000 approved these changes Sep 4, 2025
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Sep 4, 2025
@LordGrimmauld LordGrimmauld merged commit 02176ef into NixOS:master Sep 9, 2025
36 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@onny onny Awaiting requested review from onny

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

opensnitch{,-ui,ebpf}: is very broken

2 participants

@LordGrimmauld @SuperSandro2000