Skip to content

git-annex: patch another test failure#438309

Merged
vcunat merged 1 commit intoNixOS:release-25.05from
vcunat:p/git-annex-25.05
Aug 29, 2025
Merged

git-annex: patch another test failure#438309
vcunat merged 1 commit intoNixOS:release-25.05from
vcunat:p/git-annex-25.05

Conversation

@vcunat
Copy link
Member

@vcunat vcunat commented Aug 29, 2025

https://git-annex.branchable.com/bugs/flaky_test_failure_add_dup/
https://hydra.nixos.org/build/305309853

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

github-actions[bot]

This comment was marked as resolved.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 6.topic: haskell General-purpose, statically typed, purely functional programming language 4.workflow: backport This targets a stable branch labels Aug 29, 2025
@vcunat vcunat force-pushed the p/git-annex-25.05 branch from 95e5945 to de495ba Compare August 29, 2025 16:31
@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Aug 29, 2025
@vcunat vcunat dismissed github-actions[bot]’s stale review August 29, 2025 18:17

explained in commit and again in another comment

@vcunat vcunat merged commit b578892 into NixOS:release-25.05 Aug 29, 2025
28 of 32 checks passed
@vcunat vcunat deleted the p/git-annex-25.05 branch August 29, 2025 18:17
@gador
Copy link
Member

gador commented Sep 7, 2025

is there a reason this is not applied on master?
(I know it should be applied in master already, I am getting the same error on master on aarch64-linux though. See https://hydra.nixos.org/build/306633277)

@vcunat
Copy link
Member Author

vcunat commented Sep 7, 2025

The commit message in this PR says:

Not-cherry-picked-because: nixpkgs master already contains this in src

but maybe I was wrong.

@sternenseemann
Copy link
Member

This patch doesn't seem to be part of 10.20250630 which we have on master, so we should apply that on master as well. #429810 will also fix it, but will take a while to finalize.

@gador Can you propose this PR's changeagainst master?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4.workflow: backport This targets a stable branch 6.topic: haskell General-purpose, statically typed, purely functional programming language 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants