emacs.pkgs.emacs-application-framework: use xdotool when available.#438289
Merged
jian-lin merged 1 commit intoNixOS:masterfrom Sep 2, 2025
Merged
emacs.pkgs.emacs-application-framework: use xdotool when available.#438289jian-lin merged 1 commit intoNixOS:masterfrom
jian-lin merged 1 commit intoNixOS:masterfrom
Conversation
yuanw
changed the title
nixpkgs-ci
bot
added
10.rebuild-darwin: 0
nix-owners
bot
requested review from
AndersonTorres,
adisbladis,
jian-lin,
matthewbauer,
panchoh and
ttuegel
Member
|
We should have some function like "return true iff this package suports this platform". |
yuanw
force-pushed
the
eaf-build-on-darwin
branch
from
b6e9674 to
4e85c3a
Compare
panchoh
approved these changes
Aug 30, 2025
Contributor
panchoh
left a comment
panchoh
left a comment
There was a problem hiding this comment.
We should have some function like "return true iff this package suports this platform".
When that function becomes available, this could be then adjusted to make use of it.
Until such a time, I think this PR is ok as it is now, right?
nixpkgs-ci
bot
added
the
12.approvals: 1
nixpkgs-ci
bot
added
12.approvals: 2
13 tasks
jian-lin
requested changes
Aug 31, 2025
...cations/editors/emacs/elisp-packages/manual-packages/emacs-application-framework/default.nix
Outdated
Show resolved
Hide resolved
...cations/editors/emacs/elisp-packages/manual-packages/emacs-application-framework/default.nix
Outdated
Show resolved
Hide resolved
jian-lin
requested changes
Aug 31, 2025
Contributor
jian-lin
left a comment
jian-lin
left a comment
There was a problem hiding this comment.
Please follow our doc and change commit message and PR title to one of:
emacs.pkgs.emacs-application-framework: ...emacsPackages.emacs-application-framework: ...
My suggestion is emacs.pkgs.emacs-application-framework: use xdotool when available.
yuanw
force-pushed
the
eaf-build-on-darwin
branch
from
4e85c3a to
fb0ce43
Compare
yuanw
changed the title
yuanw
commented
Sep 1, 2025
...cations/editors/emacs/elisp-packages/manual-packages/emacs-application-framework/default.nix
Outdated
Show resolved
Hide resolved
jian-lin
requested changes
Sep 1, 2025
...cations/editors/emacs/elisp-packages/manual-packages/emacs-application-framework/default.nix
Outdated
Show resolved
Hide resolved
Contributor
|
Ah, a bit of nitpicking: there is an spurious . at the end of the PR title. |
yuanw
force-pushed
the
eaf-build-on-darwin
branch
from
fb0ce43 to
b022d07
Compare
jian-lin
reviewed
Sep 1, 2025
...cations/editors/emacs/elisp-packages/manual-packages/emacs-application-framework/default.nix
Outdated
Show resolved
Hide resolved
yuanw
force-pushed
the
eaf-build-on-darwin
branch
from
b022d07 to
15f3562
Compare
Contributor
|
After change the commit message to a single line of I can help you do it but that will remove your git signature. |
yuanw
force-pushed
the
eaf-build-on-darwin
branch
from
15f3562 to
0c50579
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xdotool cannot be build on darwin, this prevents eaf build on darwin
Things done
conditional use xdotool
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.