Skip to content

valkey: set upper limit for parallelism in test-suite#437794

Merged
SuperSandro2000 merged 1 commit intoNixOS:staging-25.05from
h0nIg:backport-431768-to-staging-25.05
Aug 30, 2025
Merged

valkey: set upper limit for parallelism in test-suite#437794
SuperSandro2000 merged 1 commit intoNixOS:staging-25.05from
h0nIg:backport-431768-to-staging-25.05

Conversation

@h0nIg
Copy link
Contributor

@h0nIg h0nIg commented Aug 28, 2025

#431768 failed to get backported
should help to solve #387010

-> #431768 (comment)

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@h0nIg h0nIg marked this pull request as ready for review August 28, 2025 06:06
github-actions[bot]

This comment was marked as resolved.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches. 4.workflow: backport This targets a stable branch labels Aug 28, 2025
On machines with many build cores, the tests either fail repeatedly or
don't even manage to start because all ports are blocked. For instance,
on a heavy machine with >350 threads, valkey was busy trying to find
ports for its tests for several hours:

    [...]
    Port 23380 was already busy, trying another port...
    Port 23381 was already busy, trying another port...
    Port 23382 was already busy, trying another port...
    Port 23383 was already busy, trying another port...
    Port 23384 was already busy, trying another port...
    Port 23385 was already busy, trying another port...
    Port 23386 was already busy, trying another port...
    Port 23387 was already busy, trying another port...
    Port 23388 was already busy, trying another port...
    Port 23389 was already busy, trying another port...
    Port 23390 was already busy, trying another port...

It should be noted that the tests seem to repeatedly use the same,
smallish range given it always tried to allocate ports in the range of
233xx.

(cherry picked from commit 8e4b0ab)
@h0nIg h0nIg force-pushed the backport-431768-to-staging-25.05 branch from d7a25d9 to ae6121c Compare August 28, 2025 06:12
@ofborg ofborg bot added the ofborg-internal-error Ofborg encountered an error label Aug 28, 2025
@h0nIg h0nIg mentioned this pull request Aug 28, 2025
3 tasks
@SuperSandro2000 SuperSandro2000 merged commit 63a2564 into NixOS:staging-25.05 Aug 30, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4.workflow: backport This targets a stable branch 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches. ofborg-internal-error Ofborg encountered an error

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants