Skip to content

crystal_1_17: init at 1.17.1#437526

Merged
emilazy merged 1 commit intoNixOS:masterfrom
kachick:init-crystal_1_17
Sep 3, 2025
Merged

crystal_1_17: init at 1.17.1#437526
emilazy merged 1 commit intoNixOS:masterfrom
kachick:init-crystal_1_17

Conversation

@kachick
Copy link
Member

@kachick kachick commented Aug 27, 2025 •
edited
Loading

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/. 
    > nix run .#crystal_1_17 -- eval 'puts "Hello #{41.succ}"'
Hello 42
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

@david50407
@manveru
@peterhoeg
@donovanglover

Add a 👍 reaction to pull requests you find important.

emilazy
emilazy reviewed Aug 27, 2025
View reviewed changes
pkgs/development/compilers/crystal/default.nix
version = "1.17.1";
sha256 = "sha256-+wHhozPhpIsfQy1Lw+V48zvuWCfXzT4IC9KA1AU/DLw=";
binary = binaryCrystal_1_10;
llvmPackages = llvmPackages_18;
Copy link
Member

@emilazy emilazy Aug 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, this supports up to LLVM 21 (though we haven’t bumped our LLVM 21 package to the stable release just yet): https://github.com/crystal-lang/crystal/blob/1.17.1/src/llvm/ext/llvm-versions.txt

(I have commits pending to bump other Crystal LLVM versions as part of dropping old LLVM versions, so just giving a heads up.)

Copy link
Member Author

@kachick kachick Aug 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the input. I chose LLVM 18 because I saw an upstream commit that seemed to depend on older versions(11 -> 18 -> 11).

However, it would be great if a newer version works too. 👍

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 6.topic: crystal Programming language - https://crystal-lang.org/ labels Aug 27, 2025
@kachick
Copy link
Member Author

kachick commented Aug 27, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 437526
Commit: 55038b891cc1b15ab454f9c6b7f21475b9f568b5

x86_64-linux

✅ 3 packages built:
  • crystal_1_17
  • crystal_1_17.bin
  • crystal_1_17.lib

aarch64-linux

✅ 3 packages built:
  • crystal_1_17
  • crystal_1_17.bin
  • crystal_1_17.lib

x86_64-darwin

✅ 3 packages built:
  • crystal_1_17
  • crystal_1_17.bin
  • crystal_1_17.lib

aarch64-darwin

✅ 3 packages built:
  • crystal_1_17
  • crystal_1_17.bin
  • crystal_1_17.lib

@kachick kachick marked this pull request as ready for review August 27, 2025 14:22
Henry-Hiles
Henry-Hiles approved these changes Aug 28, 2025
View reviewed changes
Copy link
Contributor

@Henry-Hiles Henry-Hiles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working well!

@Henry-Hiles Henry-Hiles added the 12.approvals: 1 This PR was reviewed and approved by one person. label Aug 28, 2025
@emilazy emilazy merged commit 427dbff into NixOS:master Sep 3, 2025
42 of 43 checks passed
@kachick
Copy link
Member Author

kachick commented Sep 3, 2025

Thank you for the review and merge!

@kachick kachick deleted the init-crystal_1_17 branch September 3, 2025 16:39
@emilazy emilazy mentioned this pull request Sep 3, 2025
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emilazy emilazy emilazy approved these changes

+1 more reviewer

@Henry-Hiles Henry-Hiles Henry-Hiles approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: crystal Programming language - https://crystal-lang.org/ 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kachick @emilazy @Henry-Hiles