shader-slang: 2025.14.3 -> 2025.15#437524
Merged
niklaskorz merged 1 commit intoNixOS:masterfrom Aug 27, 2025
Merged
Conversation
nixpkgs-ci
bot
added
10.rebuild-linux: 1-10
Member
|
As Slang implements the Language Server Protocol, tight version coupling shouldn't be required I think? If they do tend to be released at the same time, I don't have any issue with updating them in the same PR (but still separate commits) though. |
Member
|
niklaskorz
approved these changes
Aug 27, 2025
Member
niklaskorz
left a comment
niklaskorz
left a comment
There was a problem hiding this comment.
Looking good, thx. I'm fine with including the LLVM bump here as-is and discuss how to handle LLVM in general in a follow up.
nixpkgs-ci
bot
added
12.approvals: 1
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog: https://github.com/shader-slang/slang/releases/tag/v2025.15
See shader-slang/slang#7987 and shader-slang/slang#8031. Supersedes #436961.
@niklaskorz I did have a question: how should we handle updating Slang and its VS Code extension once #436862 lands? I feel like the ideal would be to update them in lockstep with each other so that the Slang version used by the VS Code extension matches the version on Marketplace, but that doesn't seem to necessarily match with the strategy used in Nixpkgs generally. Thoughts?
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.