python-qt: disable vulnerable Qt5 webengine by default, add Qt6 support, clean, adopt#437521
python-qt: disable vulnerable Qt5 webengine by default, add Qt6 support, clean, adopt#437521nim65s wants to merge 9 commits intoNixOS:masterfrom
Conversation
|
While here, add Qt6 support, where qtwebengine is available |
92bbb2f to
095c6f8
Compare
|
|
I wonder if we should default to the qt6 version instead... |
|
Ah wait its broken on darwin on qt6, fair enough to keep it on qt5 for now then. I don't particularly like staying on qt5, but so be it. |
|
I am considering to do this in several steps:
|
SigmaSquadron
left a comment
There was a problem hiding this comment.
Commits and diff looks good. Also builds properly on Linux.
|
rebased for Qt6.10.1 |
1ca6578 to
c27fe4f
Compare
webengine is optional: ``` extensions/PythonQt_QtAll/PythonQt_QtAll.pro 24: qtHaveModule(webenginewidgets):CONFIG += PythonQtWebEngineWidgets ``` So disable it by default to fix build following NixOS#435067
It now need way more fixes than what should be done in this python-qt PR
fix Qt6.10.1 support
|
rebased after #443046 |
|
|
|
Following decisions on "NixOS Security Discussions" on matrix, we'll drop instead |
|
ref. #480008 |
webengine is optional:
So disable it by default to fix build
following #435067
edit: while here, let's get a Qt6 version, where qtwebengine is still maintained.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.