Skip to content

fusePackages: eval and build#437198

Merged
wolfgangwalther merged 1 commit intoNixOS:masterfrom
jopejoe1:eval-fuse
Sep 2, 2025
Merged

fusePackages: eval and build#437198
wolfgangwalther merged 1 commit intoNixOS:masterfrom
jopejoe1:eval-fuse

Conversation

@jopejoe1
Copy link
Member

@jopejoe1 jopejoe1 commented Aug 26, 2025

Split from #434501

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Aug 26, 2025
@jopejoe1 jopejoe1 mentioned this pull request Aug 26, 2025
Closed
13 tasks
@nixpkgs-ci nixpkgs-ci bot added the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Aug 26, 2025
wolfgangwalther
wolfgangwalther reviewed Aug 26, 2025
View reviewed changes
Copy link
Contributor

@wolfgangwalther wolfgangwalther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oxalica could you elaborate why we need fusePackages if we have all of these (fuse2 and fuse3) exposed at the top-level already?

Would it be enough to just do inherit (callPackage ...) fuse fuse2 fuse3; or so?

@nixpkgs-ci nixpkgs-ci bot removed the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Aug 26, 2025
@oxalica
Copy link
Contributor

oxalica commented Aug 27, 2025

@oxalica could you elaborate why we need fusePackages if we have all of these (fuse2 and fuse3) exposed at the top-level already?

Would it be enough to just do inherit (callPackage ...) fuse fuse2 fuse3; or so?

fusePackages seems to be to workaround of the problem that fuse3 and fuse2 both depends on fuse-common which is one output of fuse3. The original author seems to be @primeos. Some context: #28409

I do not think it's really required now. And I lean towards removing fuse2 at all (#150502). A 6year old library as default constantly traps me if I forget specify fuse3 explicitly, and my program would silently lose many functionalities only supported since fuse3.

wolfgangwalther
wolfgangwalther reviewed Aug 27, 2025
View reviewed changes
@wolfgangwalther wolfgangwalther merged commit 59ed753 into NixOS:master Sep 2, 2025
29 of 31 checks passed
@wolfgangwalther
Copy link
Contributor

wolfgangwalther commented Sep 2, 2025

And I lean towards removing fuse2 at all (#150502).

ftr, I briefly looked into this, but this seems like a big effort!

@wolfgangwalther
Copy link
Contributor

wolfgangwalther commented Sep 2, 2025

Thank you, @jopejoe1

@jopejoe1 jopejoe1 deleted the eval-fuse branch September 2, 2025 20:40
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Sep 4, 2025

Successfully created backport PR for release-25.05:

@nixpkgs-ci nixpkgs-ci bot mentioned this pull request Sep 4, 2025
Merged
1 task
@github-actions github-actions bot added the 8.has: port to stable This PR already has a backport to the stable release. label Sep 4, 2025
nixpkgs-ci bot pushed a commit that referenced this pull request Sep 4, 2025
@jopejoe1 @github-actions
fusePackages: remove from search (#437198)
2c8fb09 
(cherry picked from commit 59ed753)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wolfgangwalther wolfgangwalther wolfgangwalther left review comments

Assignees

No one assigned

Labels

8.has: port to stable This PR already has a backport to the stable release. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jopejoe1 @oxalica @wolfgangwalther