sourceHanPackages: move packages to toplevel only#437190
Merged
wolfgangwalther merged 1 commit intoNixOS:masterfrom Jan 21, 2026
Merged
sourceHanPackages: move packages to toplevel only#437190wolfgangwalther merged 1 commit intoNixOS:masterfrom
wolfgangwalther merged 1 commit intoNixOS:masterfrom
Conversation
nixpkgs-ci
bot
added
10.rebuild-darwin: 0
13 tasks
nixpkgs-ci
bot
added
the
9.needs: reviewer
Contributor
wolfgangwalther
left a comment
wolfgangwalther
left a comment
There was a problem hiding this comment.
So these packages are already built, because they are exposed as individual top-level packages below. I'm not sure why they are additionally exposed as sourceHanPackages.
There are not going to be many implications of this change. I assume that hydra has to eval a few more packages, not sure whether that is going to make any difference.
I wonder whether the sourceHanPackages is actually needed or whether we could just do:
inherit (callPackage ..) source-han-sans ...;
@emilazy WDYT?
nixpkgs-ci
bot
added
2.status: merge conflict
jopejoe1
force-pushed
the
eval-sourceHan
branch
from
d683693 to
dba9323
Compare
nixpkgs-ci
bot
removed
the
2.status: merge conflict
jopejoe1
force-pushed
the
eval-sourceHan
branch
from
dba9323 to
9e68851
Compare
wolfgangwalther
changed the title
Contributor
|
Needs treefmt. |
jopejoe1
force-pushed
the
eval-sourceHan
branch
from
9e68851 to
4ef655a
Compare
wolfgangwalther
approved these changes
Sep 4, 2025
nixpkgs-ci
bot
added
the
12.approvals: 1
nixpkgs-ci
bot
added
the
2.status: merge conflict
qweered
approved these changes
Sep 21, 2025
Contributor
|
Needs rebase |
nixpkgs-ci
bot
added
12.approvals: 2
jopejoe1
force-pushed
the
eval-sourceHan
branch
from
4ef655a to
d6b80da
Compare
nixpkgs-ci
bot
removed
the
2.status: merge conflict
jopejoe1
force-pushed
the
eval-sourceHan
branch
from
d6b80da to
37b1f0e
Compare
jopejoe1
force-pushed
the
eval-sourceHan
branch
from
37b1f0e to
b0c0edf
Compare
Member
Author
|
Will self merge this tomorrow if there are no complaints. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split from #434501
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.