Skip to content

fcitx5-chinese-addons: disable WebEngine support on qt5 to unbreak#436892

Closed
LordGrimmauld wants to merge 1 commit intoNixOS:masterfrom
LordGrimmauld:fcitx5-chinese-addons-engine
Closed

fcitx5-chinese-addons: disable WebEngine support on qt5 to unbreak#436892
LordGrimmauld wants to merge 1 commit intoNixOS:masterfrom
LordGrimmauld:fcitx5-chinese-addons-engine

Conversation

@LordGrimmauld
Copy link
Contributor

@LordGrimmauld LordGrimmauld commented Aug 25, 2025

fixes #435067

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@LordGrimmauld LordGrimmauld mentioned this pull request Aug 25, 2025
Merged
13 tasks
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. labels Aug 25, 2025
@nix-owners nix-owners bot requested a review from poscat0x04 August 25, 2025 21:22
@LordGrimmauld
Copy link
Contributor Author

LordGrimmauld commented Aug 26, 2025

Seems this isn't actually a channel blocker, but still a good idea to unbreak

@NickCao
Copy link
Member

NickCao commented Aug 26, 2025

Merged #436892 instead.

@NickCao NickCao closed this Aug 26, 2025
@LordGrimmauld
Copy link
Contributor Author

LordGrimmauld commented Aug 26, 2025

Merged #436892 instead.

Hm? thats this very PR, wrong link?

@NickCao
Copy link
Member

NickCao commented Aug 26, 2025

Sorry, #417815

@LordGrimmauld
Copy link
Contributor Author

LordGrimmauld commented Aug 26, 2025

Yeah i just saw, that is the better (and more thorough!) fix, thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@poscat0x04 poscat0x04 Awaiting requested review from poscat0x04

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@LordGrimmauld @NickCao