llvmPackages_{20,21}.libclc: reenable#436446
Merged
alyssais merged 2 commits intoNixOS:stagingfrom Aug 29, 2025
Merged
Conversation
nixpkgs-ci
bot
added
10.rebuild-linux: 1-10
Contributor
Author
|
nix-owners
bot
requested review from
Ericson2314,
RossComputerGuy,
alyssais,
dtzWill,
lovek323,
rrbutani and
sternenseemann
nixpkgs-ci
bot
added
the
9.needs: reviewer
Member
|
Evaling as broken should be fine. |
nixpkgs-ci
bot
removed
the
9.needs: reviewer
Member
Contributor
Author
|
Closing in favor of #407738 |
Member
|
Just because we're not ready to update the default yet doesn't mean we have to wait to have working libclc… |
Contributor
Author
|
Might've jumped the gun there ^^' |
kilyanni
force-pushed
the
fix/llvm-libclc
branch
2 times, most recently
from
49ee4fe to
98b13bf
Compare
kilyanni
commented
Aug 28, 2025
Comment on lines
96
to
99
Contributor
Author
There was a problem hiding this comment.
This seemed like a typo to me, it caused buildInputs to eval as [..., [...]]. Kinda surprised that mkDerivation didn't complain about that
kilyanni
force-pushed
the
fix/llvm-libclc
branch
from
98b13bf to
378d3d4
Compare
nixpkgs-ci
bot
removed
10.rebuild-linux: 1-10
nixpkgs-ci
bot
added
the
10.rebuild-linux: 11-100
kilyanni
force-pushed
the
fix/llvm-libclc
branch
from
378d3d4 to
39bd105
Compare
Member
|
Don't we need to update the version check introduced in #429382? |
Contributor
Author
|
Do you mean lib.versionAtLeast metadata.release_version "16" && lib.versionOlder metadata.release_version "20"Right now I updated it to go up to version 21 only, as there's no version of |
Contributor
Author
|
Thanks! |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#429382 dropped the
libclcattribute ofllvmPackagesfor LLVM 20/21 because there was no appropriateSPIRV-LLVM-Translatorversion. #432015 introduced the required versions. This PR reintroduceslibclcand adjusts patches as some were applied upstream.llvmPackages_20.libclcbuilds properly.On LLVM 21 it's broken for now, as
SPIRV-LLVM-Translatorneeds nightly SPIRV Headers (see here). After manually forcingspirv-headersandspirv-toolsonto nightly versions,llvmPackages_21.libclcalso builds properly. Right now, it will evaluate as broken asspirv-llvm-translatoris marked as broken for LLVM 21 with current SPIRV version.#429382 was to fix OfBorg eval issues - is evaling as broken an issue, or only if it fails to eval at all?
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.