linuxHeaders: patch for sysinfo redefinition under musl#436218
Closed
yuyuyureka wants to merge 1 commit intoNixOS:stagingfrom
Closed
linuxHeaders: patch for sysinfo redefinition under musl#436218yuyuyureka wants to merge 1 commit intoNixOS:stagingfrom
yuyuyureka wants to merge 1 commit intoNixOS:stagingfrom
Conversation
yuyuyureka
force-pushed
the
sysinfo-musl
branch
from
a0b671c to
9fa5df7
Compare
nixpkgs-ci
bot
added
10.rebuild-linux: 501+
nix-owners
bot
requested review from
K900,
Ma27,
NeQuissimus,
TredwellGit and
alyssais
yuyuyureka
force-pushed
the
sysinfo-musl
branch
from
9fa5df7 to
07c9bf5
Compare
nixpkgs-ci
bot
added
9.needs: reviewer
Contributor
Author
|
We discussed this externally and found that in most cases the applications are wrong to include kernel.h outside of the kernel anyways, and this user (libbpf) specifically was using an outdated vendored version of netlink.h, which can be fixed by updating it. |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Things done
Ran into this while building xdp-tools (from #436206 checkout).
It seems to be a common issue with the musl headers, I'm not sure I understand it well enough to engage with upstream (Linux?). The musl people seem to agree that this include does not belong here, but removing it breaks glibc, so they add this condition.
So, I'm proposing to do what everyone else does for now.
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.