Skip to content

ruby: remove fetchFromSavannah fetcher with files from autoconf#436023

Merged
philiptaron merged 1 commit intostagingfrom
unknown repository
Aug 25, 2025
Merged

ruby: remove fetchFromSavannah fetcher with files from autoconf#436023
philiptaron merged 1 commit intostagingfrom
unknown repository

Conversation

@ghost
Copy link

@ghost ghost commented Aug 23, 2025 •
edited by ghost
Loading

Ruby erroneously uses a years old config savannah repository to un-vendor ruby's own config.guess/sub so lets just replace those files from autoconf's own output.

See: #435964

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 6.topic: ruby A dynamic, open source programming language with a focus on simplicity and productivity. labels Aug 23, 2025
@nix-owners nix-owners bot requested a review from manveru August 23, 2025 00:21
@ghost ghost requested a review from philiptaron August 23, 2025 00:23
@ghost ghost mentioned this pull request Aug 23, 2025
Merged
13 tasks
philiptaron
philiptaron approved these changes Aug 23, 2025
View reviewed changes
Copy link
Contributor

@philiptaron philiptaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM; doing a build.

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Aug 23, 2025
@philiptaron
Copy link
Contributor

philiptaron commented Aug 23, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 436023 --package ruby
Commit: 7efb80dccb21bc93e093da4c0b79d09b158be6d4

x86_64-linux

✅ 2 packages built:
  • ruby
  • ruby.devdoc (ruby.devdoc.devdoc)

@philiptaron philiptaron merged commit a2cd8c8 into NixOS:staging Aug 25, 2025
33 of 35 checks passed
@ghost ghost deleted the ruby-fix-autoconf-files branch September 6, 2025 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@manveru manveru Awaiting requested review from manveru

Assignees

No one assigned

Labels

6.topic: ruby A dynamic, open source programming language with a focus on simplicity and productivity. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@philiptaron