Skip to content

grub: replace fetchFromSavannah with fetchgit#436012

Merged
philiptaron merged 1 commit intomasterfrom
unknown repository
Aug 23, 2025
Merged

grub: replace fetchFromSavannah with fetchgit#436012
philiptaron merged 1 commit intomasterfrom
unknown repository

Conversation

@ghost
Copy link

@ghost ghost commented Aug 22, 2025

The speed cost of using fetchgit is outweighed by not relying on Savannah.

See #435964

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@ghost ghost mentioned this pull request Aug 22, 2025
Merged
13 tasks
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. labels Aug 22, 2025
@ghost ghost requested a review from philiptaron August 22, 2025 23:25
@nixpkgs-ci nixpkgs-ci bot added 9.needs: reviewer This PR currently has no reviewers requested and needs attention. and removed 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Aug 22, 2025
@philiptaron
Copy link
Contributor

philiptaron commented Aug 23, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 436012
Commit: 49c8159c804bc873183640add7c65a39955fb187

x86_64-linux

✅ 19 packages built:
  • calamares
  • calamares-nixos
  • calamares.debug
  • grub2 (grub2_light)
  • grub2.debug (grub2_light.debug)
  • grub2_efi
  • grub2_efi.debug
  • grub2_pvgrub_image
  • grub2_xen
  • os-prober
  • tests.devShellTools.nixos
  • tests.testers.lycheeLinkCheck.network
  • tests.testers.nixosTest-example
  • tests.testers.runNixOSTest-example (tests.testers.runNixOSTest-extendNixOS)
  • tests.trivial-builders.references
  • timeshift
  • woeusb
  • woeusb-ng
  • woeusb-ng.dist

@philiptaron philiptaron merged commit bf76412 into NixOS:master Aug 23, 2025
28 of 30 checks passed
@phanirithvij phanirithvij mentioned this pull request Sep 3, 2025
Closed
@europaul europaul mentioned this pull request Feb 3, 2026
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@philiptaron