lib.customisation.callPackageWith: fix line number interpolation#435941
Merged
wolfgangwalther merged 1 commit intoNixOS:masterfrom Aug 22, 2025
Merged
lib.customisation.callPackageWith: fix line number interpolation#435941wolfgangwalther merged 1 commit intoNixOS:masterfrom
wolfgangwalther merged 1 commit intoNixOS:masterfrom
Conversation
We need to use `toString` on `loc.line` because it is an int.
2 tasks
nixpkgs-ci
bot
added
10.rebuild-linux: 1-10
nix-owners
bot
requested review from
Artturin,
Ericson2314,
RossComputerGuy,
alyssais,
emilazy,
philiptaron and
reckenrode
philiptaron
approved these changes
Aug 22, 2025
Contributor
philiptaron
left a comment
philiptaron
left a comment
There was a problem hiding this comment.
Would that there were a test of this.
13 tasks
nixpkgs-ci
bot
added
the
12.approvals: 2
Contributor
Tested for real in #435928, works. But yeah a lib test would be nice in principle. Although... you'd be quickly discovering that |
Contributor
Yes, hence the subjunctive mood. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #433101 (comment)
We need to use
toStringonloc.linebecause it is an int.Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.