Skip to content

python313Packages.verilogae: switch to maintained fork#435932

Merged
emilazy merged 2 commits intoNixOS:masterfrom
emilazy:push-ypoxlusumvpp
Sep 4, 2025
Merged

python313Packages.verilogae: switch to maintained fork#435932
emilazy merged 2 commits intoNixOS:masterfrom
emilazy:push-ypoxlusumvpp

Conversation

@emilazy
Copy link
Member

@emilazy emilazy commented Aug 22, 2025

This brings support for newer versions of LLVM.

The only user is python3Packages.dmt-core, which has been failing for a couple months due to python3Packages.scikit-rf failing tests (on Linux only, since that test was already broken on Darwin). I disabled the test on Linux too and reported it upstream; python3Packages.dmt-core builds on aarch64-linux and aarch64-darwin now that it’s enabled in this PR. I haven’t done any testing beyond that.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 6.topic: python Python is a high-level, general-purpose programming language. labels Aug 22, 2025
@nixpkgs-ci nixpkgs-ci bot added 9.needs: reviewer This PR currently has no reviewers requested and needs attention. and removed 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Aug 22, 2025
jasonodoom
jasonodoom approved these changes Sep 4, 2025
View reviewed changes
Copy link
Member

@jasonodoom jasonodoom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this @emilazy!

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Sep 4, 2025
@emilazy emilazy merged commit b3091d9 into NixOS:master Sep 4, 2025
32 of 33 checks passed
@emilazy emilazy deleted the push-ypoxlusumvpp branch September 4, 2025 14:33
@emilazy emilazy mentioned this pull request Sep 4, 2025
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lugarun Lugarun Awaiting requested review from Lugarun

@jleightcap jleightcap Awaiting requested review from jleightcap

1 more reviewer

@jasonodoom jasonodoom jasonodoom approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@emilazy @jasonodoom