or-tools: enable SCIP support#435899
Merged
GaetanLepage merged 4 commits intoNixOS:masterfrom Oct 8, 2025
Merged
Conversation
nixpkgs-ci
bot
added
10.rebuild-linux: 1-10
Contributor
|
Thanks for removing the unnecessary argument from |
GaetanLepage
approved these changes
Aug 22, 2025
nixpkgs-ci
bot
added
the
12.approvals: 1
Contributor
|
GaetanLepage
previously requested changes
Aug 22, 2025
Contributor
GaetanLepage
left a comment
GaetanLepage
left a comment
There was a problem hiding this comment.
This breaks openroad.
Contributor
|
nixpkgs-ci
bot
added
10.rebuild-linux: 11-100
Member
Author
|
I rebased this on top of master, and there were lots of regressions due to the CMake bump. I fixed everything up to
@GaetanLepage does this ring a bell for you? |
13 tasks
Contributor
|
Yes, sounds like it... I don't have much more insight here. |
We don't use fetchzip anywhere.
Member
Author
|
It was indeed a wrong argument that SCIP passed to ctest - see scipopt/scip#169. I also took a closer look at the |
nixpkgs-ci
bot
added
10.rebuild-linux: 1-10
Contributor
|
Member
Author
|
Is it ok we deal with this in a followup PR? |
Contributor
Sure! |
GaetanLepage
reviewed
Oct 8, 2025
This adds a new argument, withScip, defaulting to true, which will configure or-tools with SCIP support. or-tools usually is built with SCIP support, and only tested like this, see google/or-tools#4745. However, SCIP only was introduced to nixpkgs March 2025, that's probably why or-tools in nixpkgs came without it so far. If built with SCIP support, we need to propagate scip itself, otherwise downstream cmake consumers need to set SCIP_ROOT explicitly.
GaetanLepage
approved these changes
Oct 8, 2025
Contributor
GaetanLepage
left a comment
GaetanLepage
left a comment
There was a problem hiding this comment.
All good, thanks @flokli
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a new argument, withScip, defaulting to true, which will
configure or-tools with SCIP support.
or-tools usually is built with SCIP support, and only tested like this,
considering google/or-tools#4745.
However, SCIP only was introduced to nixpkgs March 2025, that's probably why or-tools in nixpkgs came without it so far.
I successfully built both variants on aarch64-linux and x86_64-linux.
cc @FettGoenner
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.