actions/checkout: use single tmpfs with subfolders#435806
Merged
wolfgangwalther merged 1 commit intoNixOS:masterfrom Aug 22, 2025
Merged
actions/checkout: use single tmpfs with subfolders#435806wolfgangwalther merged 1 commit intoNixOS:masterfrom
wolfgangwalther merged 1 commit intoNixOS:masterfrom
Conversation
2 tasks
This fixes problems on darwin, where the new tmpfs folder would not be fully empty, but git only creates worktrees on fully empty directories.
wolfgangwalther
force-pushed
the
ci-tmpfs-darwin
branch
from
f123a04 to
fb32eb0
Compare
nixpkgs-ci
bot
added
10.rebuild-darwin: 0
nix-owners
bot
requested review from
MattSturgeon,
Mic92,
philiptaron and
zowoq
Contributor
Author
|
I double checked that all checkout times are still ~10s, i.e. they happen on tmpfs. No instances missed, no failures in my fork, nor in the pull_request trigger here. Whether it fixes the problem on darwin or not, can't be told from the results of this PR, because the failure appears only randomly. But conceptually this should 100% work, the problem is well understood and fixed that way. |
Contributor
|
Successfully created backport PR for |
1 task
github-actions
bot
added
the
8.has: port to stable
This was referenced Aug 22, 2025
Merged
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes problems on darwin, where the new tmpfs folder would not be fully empty, but git only creates worktrees on fully empty directories.
Fixes https://github.com/NixOS/nixpkgs/pull/435526/files#r2292959252
Things done
Still needs testing.
pull_requesttrigger.Add a 👍 reaction to pull requests you find important.