Skip to content

lvm2: fix static build#435567

Merged
flokli merged 1 commit intoNixOS:stagingfrom
nikstur:lvm2-static
Aug 22, 2025
Merged

lvm2: fix static build#435567
flokli merged 1 commit intoNixOS:stagingfrom
nikstur:lvm2-static

Conversation

@nikstur
Copy link
Contributor

@nikstur nikstur commented Aug 21, 2025

Fixes #429972 (comment)

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nikstur nikstur requested a review from alyssais August 21, 2025 12:47
@nikstur nikstur mentioned this pull request Aug 21, 2025
13 tasks
@nikstur nikstur requested a review from LordGrimmauld August 21, 2025 12:48
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Aug 21, 2025
Copy link
Contributor

@LordGrimmauld LordGrimmauld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but i suppose i was the one proposing this fix too, so i will wait with the merge for a second opinion.

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Aug 22, 2025
@flokli flokli merged commit 33ba748 into NixOS:staging Aug 22, 2025
26 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants