workflows/eval: pass outpaths via cachix instead of artifacts#435535
Merged
wolfgangwalther merged 2 commits intoNixOS:masterfrom Aug 22, 2025
Merged
workflows/eval: pass outpaths via cachix instead of artifacts#435535wolfgangwalther merged 2 commits intoNixOS:masterfrom
wolfgangwalther merged 2 commits intoNixOS:masterfrom
Conversation
This was referenced Aug 21, 2025
Merged
b25821b to
597e3ee
Compare
MattSturgeon
approved these changes
Aug 21, 2025
Contributor
MattSturgeon
left a comment
There was a problem hiding this comment.
Seems much simpler and should work better, in theory.
Concept and diff LGTM.
With the latest performance improvements, this only adds up to 1s, but reduces complexity in managing pinned checkouts explicitly, especially when we need *both* pinned checkouts in the next commit.
597e3ee to
2cb6e82
Compare
Contributor
Author
|
Rebased over the conflicts with #435806. |
Instead of uploading the outpaths as artifact, this uploads them via cachix. Most of all, this makes CI less brittle, because Eval in PRs will still be able to succeed, even if no workflow run for the push event could be found on the target branch. It will just take longer. This also makes moving Eval into the Merge Queue easier to do: When downloading artifacts from a different run, these would always have to match on the right event, too. By pulling from cachix, the same workflow can support target branches with merge queue and without merge queue at the same time. The latter would still use the push event, while the former could use the merge_group event. Last but not least, this should fix Eval on PRs targeting `wip-` branches and any other branches that the push event doesn't trigger on. These would never find an Eval result from the target branch and could never show rebuilds accurately. Now these PRs should work at a slightly higher runtime cost.
2cb6e82 to
c1b06db
Compare
Contributor
|
Successfully created backport PR for |
Merged
1 task
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(first commit is #435526)Instead of uploading the outpaths as artifact, this uploads them via cachix. Most of all, this makes CI less brittle, because Eval in PRs will still be able to succeed, even if no workflow run for the push event could be found on the target branch. It will just take longer.
This also makes moving Eval into the Merge Queue easier to do: When downloading artifacts from a different run, these would always have to match on the right event, too. By pulling from cachix, the same workflow can support target branches with merge queue and without merge queue at the same time. The latter would still use the push event, while the former could use the merge_group event.
Last but not least, this should fix Eval on PRs targeting
wip-branches and any other branches that the push event doesn't trigger on. These would never find an Eval result from the target branch and could never show rebuilds accurately. Now these PRs should work at a slightly higher runtime cost.Things done
Add a 👍 reaction to pull requests you find important.