Skip to content

nixos/profiles/bashless: init#435428

Merged
nikstur merged 6 commits intoNixOS:staging-nixosfrom
nikstur:bashless
Oct 10, 2025
Merged

nixos/profiles/bashless: init#435428
nikstur merged 6 commits intoNixOS:staging-nixosfrom
nikstur:bashless

Conversation

@nikstur
Copy link
Contributor

@nikstur nikstur commented Aug 20, 2025 •
edited
Loading

Concludes #428908

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nikstur nikstur mentioned this pull request Aug 19, 2025
Closed
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 6.topic: systemd Software suite that provides an array of system components for Linux operating systems. labels Aug 20, 2025
@h7x4 h7x4 added 8.has: module (new) This PR adds a module in `nixos/` 8.has: tests This PR has tests labels Sep 11, 2025
@nixpkgs-ci nixpkgs-ci bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Sep 14, 2025
@nikstur nikstur changed the base branch from staging to master September 23, 2025 13:08
@nixpkgs-ci nixpkgs-ci bot closed this Sep 23, 2025
@nixpkgs-ci nixpkgs-ci bot reopened this Sep 23, 2025
@nikstur nikstur marked this pull request as ready for review September 23, 2025 14:17
@nix-owners nix-owners bot requested review from aanderse and flokli September 23, 2025 14:19
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-nixos-tests This PR causes rebuilds for all NixOS tests and should normally target the staging branches. and removed 2.status: merge conflict This PR has merge conflicts with the target branch labels Sep 23, 2025
@boomshroom
Copy link
Contributor

boomshroom commented Sep 23, 2025

Would there be an option to remove bash from the initrd without removing it from the full system? I think it would be reasonable to want a slimmer / more locked down early boot stage without necessarily removing behavior from the final booted system.

@nikstur
Copy link
Contributor Author

nikstur commented Sep 25, 2025

Would there be an option to remove bash from the initrd without removing it from the full system? I think it would be reasonable to want a slimmer / more locked down early boot stage without necessarily removing behavior from the final booted system.

I think that would be a good idea. Maybe something like boot.initrd.systemd.enableShell.

ElvishJerricco
ElvishJerricco requested changes Sep 26, 2025
View reviewed changes
@nikstur nikstur force-pushed the bashless branch 2 times, most recently from 24d5e16 to 48eacf6 Compare September 28, 2025 19:29
Ma27
Ma27 reviewed Oct 9, 2025
View reviewed changes
Copy link
Member

@Ma27 Ma27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please retarget to staging-nixos since this causes a rebuild of all nixos tests.
Everything in there will usually be merged with the next kernel update, i.e. ~weekly.

See also https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#changes-rebuilding-all-nixos-tests

@nikstur nikstur force-pushed the bashless branch 2 times, most recently from a9c7c1d to 27edaf0 Compare October 9, 2025 21:50
@nikstur nikstur marked this pull request as draft October 9, 2025 21:51
@nikstur nikstur changed the base branch from master to staging-nixos October 9, 2025 21:52
@nixpkgs-ci nixpkgs-ci bot closed this Oct 9, 2025
@nixpkgs-ci nixpkgs-ci bot reopened this Oct 9, 2025
nikstur added 6 commits October 9, 2025 23:52
@nikstur
nixos/shadow: use /bin/sh as default userDefaultShell
e8b9d87 
The default was previously set by the bash module. It's not set directly
here (to the compiled in value) of the shadow package to allow disabling
the bash module.

Note that this doesn't mean that the effective default shell of a normal
NixOS installation has changed. It is still bash.
@nikstur
nixos/shells-environment: add environment.shell.enable option
70852ab
@nikstur
nixos/top-level: only include preSwitchChecks when they are set
26cf6ff
@nikstur
nixos/systemd-initrd: add boot.initrd.systemd.shell.enable option
8002da1
@nikstur
nixos/test-instrumentation: add backdoor option
9cff1cc 
This allows using the test-instrumentation without the backdoor. This is
useful for example for bashless tests.
@nikstur
nixos/profiles: add bashless profile
0e0be13
@nikstur nikstur marked this pull request as ready for review October 9, 2025 21:54
@nikstur
Copy link
Contributor Author

nikstur commented Oct 9, 2025

Please retarget to staging-nixos

Done. Thanks for pointing it out!

@nikstur nikstur requested review from ElvishJerricco and Ma27 October 9, 2025 21:55
@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Oct 10, 2025
@nikstur nikstur merged commit 7226218 into NixOS:staging-nixos Oct 10, 2025
33 of 36 checks passed
@nikstur nikstur deleted the bashless branch October 10, 2025 21:08
@Ericson2314
Copy link
Member

Ericson2314 commented Oct 23, 2025

Glad to see this merged! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ElvishJerricco ElvishJerricco ElvishJerricco approved these changes

@r-vdp r-vdp Awaiting requested review from r-vdp

@arianvp arianvp Awaiting requested review from arianvp

@LordGrimmauld LordGrimmauld Awaiting requested review from LordGrimmauld

@flokli flokli Awaiting requested review from flokli

@aanderse aanderse Awaiting requested review from aanderse

@Ma27 Ma27 Awaiting requested review from Ma27

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: systemd Software suite that provides an array of system components for Linux operating systems. 8.has: module (new) This PR adds a module in `nixos/` 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: tests This PR has tests 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-nixos-tests This PR causes rebuilds for all NixOS tests and should normally target the staging branches. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@nikstur @boomshroom @Ericson2314 @ElvishJerricco @Ma27 @h7x4