Skip to content

bazel_7: fix build with modern Clang on macOS#435110

Merged
emilazy merged 1 commit intoNixOS:masterfrom
emilazy:push-ympuwmlqqpop
Sep 2, 2025
Merged

bazel_7: fix build with modern Clang on macOS#435110
emilazy merged 1 commit intoNixOS:masterfrom
emilazy:push-ympuwmlqqpop

Conversation

@emilazy
Copy link
Member

@emilazy emilazy commented Aug 19, 2025

This would also work for Bazel 6, but it’s being removed anyway.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@emilazy
bazel_7: fix build with modern Clang on macOS
2a29096 
This would also work for Bazel 6, but it’s being removed anyway.
@emilazy emilazy requested a review from a team August 19, 2025 21:59
@nix-owners nix-owners bot requested a review from Profpatsch August 19, 2025 22:01
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Aug 19, 2025
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Aug 19, 2025
@emilazy emilazy mentioned this pull request Aug 21, 2025
Merged
13 tasks
@phanirithvij phanirithvij mentioned this pull request Aug 29, 2025
Merged
@hzeller hzeller mentioned this pull request Sep 1, 2025
Closed
13 tasks
hzeller
hzeller approved these changes Sep 1, 2025
View reviewed changes
Copy link
Contributor

@hzeller hzeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on that.
I observe two PRs where the CI is currently failing due to bazel 7 on Darwin, so this is very welcome.

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Sep 1, 2025
@emilazy
Copy link
Member Author

emilazy commented Sep 2, 2025

I am afraid I don’t understand the ofborg failure there at all. bazel_7 has already been building successfully on aarch64-darwin; this PR was just to get rid of the old LLVM ping. It seems like the build may fail in certain environments (though ofborg uses the sandbox) and perhaps it was not cached when ofborg ran its test?

This PR should at least not make the situation any worse, but I would recommend using @ofborg build to retry the builds on PRs with that problem. I suspect there may be demons lurking in the Bazel build.

@emilazy emilazy merged commit f5d3ee9 into NixOS:master Sep 2, 2025
33 of 34 checks passed
@emilazy emilazy deleted the push-ympuwmlqqpop branch September 2, 2025 16:54
This was referenced Sep 2, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Profpatsch Profpatsch Awaiting requested review from Profpatsch

@mboes mboes Awaiting requested review from mboes

@groodt groodt Awaiting requested review from groodt

@ylecornec ylecornec Awaiting requested review from ylecornec

@avdv avdv Awaiting requested review from avdv

@uri-canva uri-canva Awaiting requested review from uri-canva

@olebedev olebedev Awaiting requested review from olebedev

@aherrmann aherrmann Awaiting requested review from aherrmann

1 more reviewer

@hzeller hzeller hzeller approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@emilazy @hzeller