Required some changes after the 5.3 update, works again now.

@trofi I added myself as a bash maintainer, would you also be okay with adding yourself? You've been doing a great job with maintenance :D. Since you don't have a maintainer entry yet, you'd need to create one in a separate PR though: https://github.com/NixOS/nixpkgs/blob/master/maintainers/maintainer-list.nix

@trofi [...] would you also be okay with adding yourself?

No, I'll pass. I only have time for small drive-by changes.

10 more tests were failing on Darwin, so I now just marked the test derivation as broken on Darwin because I don't want to bother trying to make them work or marking them as broken individually.

If we spend more time on this, let's focus on the Linux tests first.

I now also changed the test patch to collect all failures instead of just failing at the first one

@balsoft In addition to addressing your comment (and other improvements to the patch), I removed this:

# Fail if diff fails at the end of each test script
for check in tests/run-*; do
  # Append "exit $?" at the very end of the file
  sed -i '$aexit $?' "$check"
done

Everything works (or fails when expected) as it should, I guess that part isn't necessary after all. As a reminder, all the test files look like

${THIS_SH} ./arith.tests > ${BASH_TSTOUT} 2>&1
diff ${BASH_TSTOUT} arith.right && rm -f ${BASH_TSTOUT}

If the diff fails (aka there is a diff), the output doesn't get removed and it exits with 1. That exit code is already caught in the if sh $x; then, so nothing else should be needed.

@trofi Could you have another look? We now also submitted two of the patches upstream to improve test support: https://lists.gnu.org/archive/html/bug-bash/2025-10/msg00054.html and https://lists.gnu.org/archive/html/bug-bash/2025-10/msg00055.html

I'll merge this, we can improve this over time if necessary