Skip to content

ante: unstable-2023-12-18 -> 0-unstable-2025-07-12#434788

Merged
emilazy merged 1 commit intoNixOS:masterfrom
emilazy:push-oulrkvkrvxpp
Aug 19, 2025
Merged

ante: unstable-2023-12-18 -> 0-unstable-2025-07-12#434788
emilazy merged 1 commit intoNixOS:masterfrom
emilazy:push-oulrkvkrvxpp

Conversation

@emilazy
Copy link
Member

@emilazy emilazy commented Aug 18, 2025

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Aug 18, 2025
@nix-owners nix-owners bot requested a review from ehllie August 18, 2025 18:42
wolfgangwalther
wolfgangwalther approved these changes Aug 18, 2025
View reviewed changes
Copy link
Contributor

@wolfgangwalther wolfgangwalther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 434788
Commit: 35931d8a9f96e0605da12f29f8bf192cbfa73865

x86_64-linux

✅ 1 package built:
  • ante

aarch64-linux

✅ 1 package built:
  • ante

x86_64-darwin

✅ 1 package built:
  • ante

aarch64-darwin

✅ 1 package built:
  • ante

LGTM, with some non-blocking nits.

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Aug 18, 2025
@emilazy emilazy force-pushed the push-oulrkvkrvxpp branch from 35931d8 to 9ef1336 Compare August 19, 2025 15:08
@emilazy emilazy enabled auto-merge August 19, 2025 15:10
@emilazy emilazy merged commit 05eeafd into NixOS:master Aug 19, 2025
24 of 28 checks passed
@emilazy emilazy mentioned this pull request Sep 4, 2025
Merged
13 tasks
@emilazy emilazy deleted the push-oulrkvkrvxpp branch September 17, 2025 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wolfgangwalther wolfgangwalther wolfgangwalther approved these changes

@ehllie ehllie Awaiting requested review from ehllie

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@emilazy @wolfgangwalther