{irods,irods-icommands}: 4.3.3 -> 5.0.1#434776
Merged
emilazy merged 1 commit intoNixOS:masterfrom Sep 5, 2025
Merged
Conversation
This was referenced Aug 18, 2025
Closed
Closed
nixpkgs-ci
bot
added
10.rebuild-linux: 1-10
13 tasks
Member
Author
Contributor
|
@emilazy Oh, sorry I missed the info! |
bzizou
approved these changes
Sep 5, 2025
Contributor
bzizou
left a comment
bzizou
left a comment
There was a problem hiding this comment.
Tested the irods-icommands on a linux host connected to a irods 4.3.3 server (as I don't have a 5.0.1 in production yet), and it works perfectly!
Contributor
|
thanks for this upgrade and refactoring! |
nixpkgs-ci
bot
added
12.approvals: 1
Member
Author
|
Thank you for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks to the truly heroic upstream work of @SwooshyCueb, we can remove almost all of the complicated overrides and pins of old versions that these packages required and move them into
pkgs/by-name.@bzizou Sorry for doing such a drastic rework of your package! I am working on cleaning up old LLVMs – we are going to remove many EOL compilers before the 25.11 release, so this package needed changes – and got a little carried away as I discovered how much the new version fixes. I don’t use this software myself, so I’d very much appreciate your review and testing. Let me know if you think this needs a release note, as well. The move to
pkgs/by-namewill also allow you to merge automatic updates from @r-ryantm yourself in future.Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.