androidndkPackages_{21,23,24,25,26}: drop#434649
Conversation
nix-owners
bot
requested review from
Artturin,
Ericson2314,
JohnRTitor,
RossComputerGuy,
adrian-gierakowski,
alyssais,
hadilq,
philiptaron and
reckenrode
nixpkgs-ci
bot
added
10.rebuild-linux: 1-10
|
Oh yes, these are quite cursed and I was strongly considering nuking them from orbit anyway but didn't get it in time for 25.05. This is a good first step, I have been somewhat passively looking into moving them all into androidenv since we would be able to automatically figure out which is the LTS based on Android repo metadata, so there would be no more version hardcoding, just LTS and latest, as this PR informally formalizes. |
nixpkgs-ci
bot
added
the
12.approvals: 1
lib/systems/examples.nix
Outdated
There was a problem hiding this comment.
Let's go 35 (Android 15) for all these, this basically defines the latest native ABI level the Android SDK can use and doesn't preclude compatibility.
With 33 or 35 on my relatively recent phone:
$ NIXPKGS_ALLOW_UNFREE=1 nom-build -A pkgsCross.aarch64-android-prebuilt.hello
<wait for it>
$ adb push result/bin/hello /data/local/tmp
result/bin/hello: 1 file pushed, 0 skipped. 214.6 MB/s (59032 bytes in 0.000s)
$ adb shell /data/local/tmp/hello
Hello, world!
EOL and depend on EOL LLVMs.
emilazy
force-pushed
the
push-nopwsoqpvuln
branch
from
016d4f8 to
5381f4d
Compare
|
LTS + latest sounds like a good policy to me. Always in favour of things that will reduce references to old toolchains. |
nixpkgs-ci
bot
added
8.has: changelog
3 participants
@numinit Hello! I would appreciate your assistance in my insatiable quest to delete end‐of‐life compilers. These NDKs not only depend on EOL LLVM versions but they’re also EOL themselves according to Google so this is kind of a double treat for me.
I don’t have much Android experience, though, so let me know if the NDK bump to the latest LTS here makes sense, or if we should just jump to the latest stable, or what, and if we should be bumping the SDK at the same time or not. I have not really tested any of this. Let me know if you want a release note too.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.