Skip to content

zig_0_12: drop#434644

Merged
emilazy merged 4 commits intoNixOS:masterfrom
emilazy:push-lmxvzumnkpzq
Aug 18, 2025
Merged

zig_0_12: drop#434644
emilazy merged 4 commits intoNixOS:masterfrom
emilazy:push-lmxvzumnkpzq

Conversation

@emilazy
Copy link
Member

@emilazy emilazy commented Aug 18, 2025 •
edited
Loading

EOL LLVM unmaintained compiler etc. etc.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

emilazy added 4 commits August 18, 2025 06:09
@emilazy
clipbuzz: drop
70c8c6b
@emilazy
dt: bump to Zig 0.13
e0216a9
@emilazy
cyber: drop
5db9f62 
There are PRs upstream to support newer Zig versions, but no movement,
and the author has no GitHub activity since December:

* <fubark/cyber#101>
* <fubark/cyber#104>
@emilazy
zig_0_12: drop
ba90f3c
@nix-owners nix-owners bot requested a review from figsoda August 18, 2025 05:55
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 8.has: changelog This PR adds or changes release notes 6.topic: zig Zig is an imperative, general-purpose, statically typed, compiled system programming language. 8.has: documentation This PR adds or changes documentation labels Aug 18, 2025
@nix-owners nix-owners bot requested a review from booniepepper August 18, 2025 05:59
@RossComputerGuy
Copy link
Member

RossComputerGuy commented Aug 18, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 434644
Commit: ba90f3c54c63b5c4232644ba6e7564a6021d4237

aarch64-linux

⏩ 1 package blacklisted:
  • tests.nixos-functions.nixos-test
❌ 1 package failed to build:
  • dt
✅ 1 package built:
  • nixpkgs-manual
Error logs: `aarch64-linux`
dt 
Running phase: unpackPhase
@nix { "action": "setPhase", "phase": "unpackPhase" }
unpacking source archive /nix/store/0yi5yn0nwav7x6ywg6z4qai9jn7mkyp9-source
source root is source
Running phase: patchPhase
@nix { "action": "setPhase", "phase": "patchPhase" }
Running phase: updateAutotoolsGnuConfigScriptsPhase
@nix { "action": "setPhase", "phase": "updateAutotoolsGnuConfigScriptsPhase" }
Running phase: configurePhase
@nix { "action": "setPhase", "phase": "configurePhase" }
no configure script, doing nothing
Running phase: buildPhase
@nix { "action": "setPhase", "phase": "buildPhase" }
zig build flags: -Dcpu=baseline --release=safe
thread 231 panic: reached unreachable code
Panicked during a panic. Aborting.
error: the following build command crashed:
/build/source/.zig-cache/o/972c7c6d83cfffe63a9a2c3d9c89a952/build /nix/store/zzvvbvs14dqh0vfbz9lrdmvyj3b4kqmj-zig-0.13.0/bin/zig /build/source /build/source/.zig-cache /build/tmp.lfMzpQKLKc --seed 0x8e21abc6 -Zece92b047a8bc3c0 -Dcpu=baseline --release=safe --verbose

@emilazy
Copy link
Member Author

emilazy commented Aug 18, 2025

Uh, no idea what’s going on with that compiler crash. I could have sworn it built on aarch64-darwin, but actually I’m getting a test failure there now that looks pre‐existing. But it builds on aarch64-linux for me. Is that failure reproducible? I can take a closer look tomorrow.

@RossComputerGuy
Copy link
Member

RossComputerGuy commented Aug 18, 2025

It's the 64k page size thing. Forgot that versions < 14 don't support page sizes > 4k on aarch64-linux.

@emilazy
Copy link
Member Author

emilazy commented Aug 18, 2025

Is there anything else you’d like to see here?

RossComputerGuy
RossComputerGuy approved these changes Aug 18, 2025
View reviewed changes
Copy link
Member

@RossComputerGuy RossComputerGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, gtg

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Aug 18, 2025
@emilazy emilazy merged commit 00e1d59 into NixOS:master Aug 18, 2025
34 of 36 checks passed
@emilazy emilazy deleted the push-lmxvzumnkpzq branch August 18, 2025 18:32
@emilazy emilazy mentioned this pull request Sep 4, 2025
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RossComputerGuy RossComputerGuy RossComputerGuy approved these changes

@figsoda figsoda Awaiting requested review from figsoda

@booniepepper booniepepper Awaiting requested review from booniepepper

Assignees

No one assigned

Labels

6.topic: zig Zig is an imperative, general-purpose, statically typed, compiled system programming language. 8.has: changelog This PR adds or changes release notes 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@emilazy @RossComputerGuy