Conversation
This was already bumped from LLVM 12 in <NixOS#379273> with 13 seemingly being an arbitrary choice, so… optimistically let’s just unpin it entirely?
The bugs no longer reproduce as of the latest release.
Fails to build on Darwin, but because of `sigtool` limitations at install time, not because of LLVM.
Upstream is already using LLVM 18 and it builds fine with the default.
The package is broken (even on 3.11), so I can’t test this but also don’t really care. It should probably just be dropped at this point.
It’s broken anyway.
c5b02a1 to
e32980b
Compare
All good! |
Can you test the Mathematica build @rafaelrc7? |
|
I went trough the failures there and I can't see any regressions. Some flaky builds that became fine on a retry, but most already broken on master. |
Since this is an |
Sorry, but we can’t keep around LLVM 16 just for this. Upstreams are unlikely to support Nixpkgs packaging anyway. It does build with the default version.
Nobody is going to fix the warnings because it’s unmaintained and silencing them won’t make them go away. This will be marked `knownVulnerabilities` soon enough, too. We don’t need `overrideLibcxx` because LLVM 19 is currently the default and we’ll switch to the system C++ library on Darwin when bumping it.
Unclear why this reference and no other was pinned. It builds.
Per their [`configure` script] (but not their documentation!), they support up to LLVM 20. [`configure` script]: <https://github.com/ghdl/ghdl/blob/v5.1.1/configure#L312-L327>
None of the libraries reference this.
This was using `llvmPackages_latest` before that became an alias.
e32980b to
dd781e6
Compare
|
|
Approving everything except Mathematica changes, but we might as well merge them and figure that out later - it sounds like there are other ways out of there, if its broken right now from your latest comment. |
I love to unpin compilers.
I actually made sure everything builds this time, other than the things that were already broken, and Mathematica, because I don’t have Mathematica and I don’t think the previous bump was tested either.
(Hope you don’t mind me pinging you for these, @wolfgangwalther!)
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.