Conversation
nixpkgs-ci
bot
added
10.rebuild-linux: 1-10
wolfgangwalther
left a comment
wolfgangwalther
left a comment
There was a problem hiding this comment.
A few notes, none of which are about this PR:
- There is no
metain this package. - The upstream repo redirects to https://github.com/intel/cryptography-primitives.
| # Yes, it seems bad for a cryptography library to trigger this | ||
| # warning. We previously pinned an EOL GCC which avoided it, but this | ||
| # issue is present regardless of whether we use a compiler that flags | ||
| # it up or not; upstream just doesn’t test with modern compilers. | ||
| env.NIX_CFLAGS_COMPILE = "-Wno-error=stringop-overflow"; |
There was a problem hiding this comment.
Potentially mention this issue, which seems related?
There was a problem hiding this comment.
Hmm, that doesn’t seem to include the default‐error warning that breaks the build here, and triggers even without -Wall, so I’m not sure it’s directly related other than … being a reason I wouldn’t use this library for anything myself.
They nominally claim support for GCC 14, though. Go figure. I could report an issue upstream if you want, but the upstream responses are generally not very encouraging.
| pname = "ipp-crypto"; | ||
| version = "2021.11.1"; |
There was a problem hiding this comment.
This seems to be outdated, upstream seems to have changed its tags:
Maybe a newer version builds differently?
There was a problem hiding this comment.
I tried HEAD and it failed in exactly the same way. This is internal to sgx-sdk and this version more closely matches the version pinned as a submodule in that repository (though it’s actually a patch version bump ahead), so I’m inclined to leave it to the sgx-sdk maintainers to handle bumping it, given that it doesn’t affect the warning.
There was a problem hiding this comment.
This is internal to
sgx-sdk
Ah, I see. This also explains why there is no meta section, I guess.
|
nixpkgs-ci
bot
added
the
12.approvals: 1
2 participants
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.