kbd: link compression libs directly#434001
Merged
flokli merged 2 commits intoNixOS:stagingfrom Aug 19, 2025
Merged
Conversation
Contributor
Author
|
cc @flokli |
nixpkgs-ci
bot
added
10.rebuild-linux: 501+
Member
|
I ran the VM tests as well, but didn't get to tinker with it interactively until before it got merged upstream. The Nix changes look good, if you've been running this sucessfully, I'd suggest to update the expression to point to the merge commit, and land this. |
Link compression libs directly. - Clean up derivation - Remove NIX_LDFLAGS which achieved nothing. Static compilation works without it on master. It's unclear what this should've every achieved. kbd doesn't link against audit. - Build directly from source now instead of the preconfigured tarball (avoids xz-style issues)
nikstur
force-pushed
the
kbd-compression
branch
from
ffb2ee2 to
b254ec7
Compare
nix-owners
bot
requested review from
HarisDotParis,
bjornfor,
davidak,
prusnak and
robsliwi
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
without it on master. It's unclear what this should've ever achieved.
kbd doesn't link against audit.
(avoids xz-style issues)
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.