python3Full: obsolete and remove#433833
Conversation
emilazy
left a comment
emilazy
left a comment
There was a problem hiding this comment.
There are tests in Lib/test/test_tkinter and Lib/test/tkinterdata that we should probably try to preserve and run.
There are a couple downstream users in CPython: turtle (and turtledemo) and idlelib (including the IDLE application). I guess we could bundle them into this package, but it probably makes more sense to apply the same trick to those as separate module packages. They’re both used a fair amount in education, I think, so it would be best to keep them available unless they’re onerous to package.
mweinelt
force-pushed
the
tkinter-standalone
branch
from
1833b98 to
6cb98ef
Compare
nixpkgs-ci
bot
added
10.rebuild-linux: 501+
These are really annoying to get to run, so I'd rather not.
They are importable with standard python that has tkinter in its python path. At least turtle crashes without tkinter. |
mweinelt
force-pushed
the
tkinter-standalone
branch
from
6cb98ef to
3a8d500
Compare
LordGrimmauld
left a comment
LordGrimmauld
left a comment
There was a problem hiding this comment.
Implementation looks sane.
tkinter does seem to work, at least i can import it and launch a window. Test fails don't look nice, but this is probably better than before, where we had no tests at all.
mweinelt
force-pushed
the
tkinter-standalone
branch
from
3a8d500 to
39ab9d4
Compare
mweinelt
force-pushed
the
tkinter-standalone
branch
from
39ab9d4 to
4067e4f
Compare
|
Needs to target staging, other than that looks reasonable enough |
mweinelt
force-pushed
the
tkinter-standalone
branch
from
d66e61d to
9dfdd7c
Compare
nixpkgs-ci
bot
removed
the
11.by: package-maintainer
This comment was marked as outdated.
This comment was marked as outdated.
LordGrimmauld
left a comment
LordGrimmauld
left a comment
There was a problem hiding this comment.
tkinter changes work locally, diff on py full looks reasonable but i didn't get to build it yet
nixpkgs-ci
bot
added
the
12.approvals: 1
nixpkgs-ci
bot
added
10.rebuild-darwin: 1001-2500
|
Good catch, applied. |
mweinelt
force-pushed
the
tkinter-standalone
branch
from
4776f12 to
2ad345d
Compare
nix-owners
bot
requested review from
adevress,
amiloradovsky,
bjornfor,
dotlambda,
fpletz,
prusnak and
thoughtpolice
This escapes infinite recursion, because Python cannot depend on bluez due to infinite recursion on multiple paths. But it only wants bluetooth.h at build time, so this is sufficient. In 5.84 the source path changes from lib/ to lib/bluetooth, which will require an update to the install phase.
The default python now provides bluetooth support.
Bluetooth support is now built into the default build. The X11 support is realized outside the Python interpreter by including the tkinter module from the package set.
mweinelt
force-pushed
the
tkinter-standalone
branch
from
2ad345d to
2877deb
Compare
|
Added another comment why the bluez-headers package has the src fod and not bluez. |
| lgpl21Plus | ||
| mit | ||
| ]; | ||
| meta = bluez-headers.meta // { |
|
May I ask, what should I use instead of python3Full? I was using it as a way to have the latest stable python3 installed. I see there is no python3 or something to keep up with the latest stable version of python3. Should I use something like python314 and change it each time there is an update? (Disclaimer: I may be doing this wrong all along.) (Is what Im saying a https://xkcd.com/1172/ case?) |
of course there is - just use |
|
Ohh thanks! I guess it was hidden in the numerous packages in search.nixos.org. Cool! |
8 participants
Why? python3Full must die.
Wondering if there is more beautiful way to cobble the source together.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.