Care to explain what this is fixing ?

It would be nice, just for my own info, to compare the closure size, before and after this patch.

It would be nice, just for my own info, to compare the closure size, before and after this patch.

yes! it would be great to see some real numbers on that! to be clear though... the improvements only help users who aren't running nixos... and only if no other dependencies are pulling in systemd, of course

please do share your results if you don't mind @drupol ❤️

i miss the days when the PR template asked users to include that information... 😅

I have no access to a computer these days, just a smartphone... So I could do it, but it need to wait until the 25.

before patch:

aaron@framework ~/nixpkgs (master)> nix path-info -Sh .#php
/nix/store/s4kv9bzqawhqcyjg9xm2hji3jap6d6kd-php-with-extensions-8.4.11   357.0 MiB

after patch:

aaron@framework ~/nixpkgs (master)> nix path-info -Sh .#php
/nix/store/dh375svy6ycjlir3xqg7nwvrzkq9s7v3-php-with-extensions-8.4.11   251.8 MiB

@vog our friends running php outside of nixos thank you for your service 🫡

Amazing improvements, thanks !

Could you retarget this PR on staging please (PR causes a lot of rebuilds and doesn't seem urgent)? See CONTRIBUTING.md in the root of this repo for how to do that if this is your first time.

Could you retarget this PR on staging please (PR causes a lot of rebuilds and doesn't seem urgent)? See CONTRIBUTING.md in the root of this repo for how to do that if this is your first time.

@r-vdp Done.

Merging despite CI failures due to what was explained by @wolfgangwalther in #433749

Successfully created backport PR for staging-25.05:

• [Backport staging-25.05] php: fix systemdLibs dependency #434835

@vog I tried to replace systemd with systemdLibs in util-linux and it looks like everything works.

The gain in size is significant:

❯ nix path-info -Sh ./result-bin
/nix/store/qx5wjl2d6bpy82vwkvv9hfm3nfbsm44r-util-linux-2.41.1-bin         88.1 MiB
❯ jj new master
❯ nix-build -A util-linux
/nix/store/ad5skbqn01fbmgwd0b879zy5x5skgxj1-util-linux-2.41.1-bin
❯ nix path-info -Sh ./result-bin
/nix/store/ad5skbqn01fbmgwd0b879zy5x5skgxj1-util-linux-2.41.1-bin        206.7 MiB

How to make sure doing such a thing won't break anything?

@vog I tried to replace systemd with systemdLibs in util-linux and it looks like everything works.

The gain in size is significant:

❯ nix path-info -Sh ./result-bin
/nix/store/qx5wjl2d6bpy82vwkvv9hfm3nfbsm44r-util-linux-2.41.1-bin         88.1 MiB
❯ jj new master
❯ nix-build -A util-linux
/nix/store/ad5skbqn01fbmgwd0b879zy5x5skgxj1-util-linux-2.41.1-bin
❯ nix path-info -Sh ./result-bin
/nix/store/ad5skbqn01fbmgwd0b879zy5x5skgxj1-util-linux-2.41.1-bin        206.7 MiB

How to make sure doing such a thing won't break anything?

This is great!

Given that util-linux independent from systemd, and on many systems compiled completely without systemd support at all, I don't see any risk here if it compiles without any errors.

Also note that this is really mostly affecting people using nixpkgs as package manager, not users of NixOS - because NixOS, as OS, ships with a full systemd anyways.

As a general note, I have the impression that practically all "normal" packages (i.e. not Nix modules or similar) that depend on the "systemd" derivation do so simply because they didn't notice the "systemdLibs" derivation that they are actually supposed to have depended on.