bubblewrap: add dev output to fix static build#433640
Merged
wolfgangwalther merged 1 commit intoNixOS:stagingfrom Aug 17, 2025
Merged
bubblewrap: add dev output to fix static build#433640wolfgangwalther merged 1 commit intoNixOS:stagingfrom
wolfgangwalther merged 1 commit intoNixOS:stagingfrom
Conversation
nixpkgs-ci
bot
added
10.rebuild-linux: 501+
Contributor
Author
|
This reduces the closure size of Before: After: So we have a reduction from 28 MiB to 240 KiB. |
Contributor
Author
|
Related: #433641. |
13 tasks
Contributor
|
Too many rebuilds - please target staging. |
vog
force-pushed
the
bubblewrap-add-dev
branch
from
f20ef0b to
0931102
Compare
Contributor
Author
@wolfgangwalther Done. |
Contributor
The PR title says it "fixes" the static build, but this comment indicates that the static build worked before and this is just about a closure size change. Could you clarify and adjust the commit message / PR title accordingly if that needs change? |
Contributor
|
wolfgangwalther
approved these changes
Aug 17, 2025
Contributor
I tested, and it built fine before. Thus I changed the commit message accordingly while squash merging the single commit. |
Contributor
|
Successfully created backport PR for |
github-actions
bot
added
the
8.has: port to stable
1 task
wolfgangwalther
added a commit
that referenced
this pull request
Aug 17, 2025
…ld (#434455) bubblewrap: add dev output to reduce closure size of static build (#433640) (cherry picked from commit f2b5d60) Co-authored-by: Volker Diels-Grabsch <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.