lib: cleanup after bump of minver#433101
Merged
wolfgangwalther merged 2 commits intoNixOS:masterfrom Aug 22, 2025
Merged
Conversation
This could have been done a while ago, minver has been > 2.3.4 for quite some time already.
minver is now at 2.18, which means that `fetchGit` support shallow clones and submodules for sure.
2 tasks
nix-owners
bot
requested review from
Artturin,
Ericson2314,
RossComputerGuy,
alyssais,
emilazy,
hsjobeki,
infinisil,
philiptaron and
reckenrode
nixpkgs-ci
bot
added
10.rebuild-linux: 1-10
emilazy
reviewed
Aug 12, 2025
Member
emilazy
left a comment
emilazy
left a comment
There was a problem hiding this comment.
Looks like nothing here will break the minver check code path (which I think is important to keep working on 2.3 for now).
BTW, maybe we should add a check to other entry points like nixos/{default,eval-config}.nix and the flake.
sternenseemann
added a commit
to sternenseemann/nix
that referenced
this pull request
Aug 14, 2025
See NixOS/nixpkgs@fa0cba1. Note that NixOS/nixpkgs#433101 will likely require backporting further changes from later C++ Nix versions in order to keep things working.
13 tasks
sternenseemann
added a commit
to sternenseemann/nix
that referenced
this pull request
Aug 14, 2025
See NixOS/nixpkgs@fa0cba1. We'll see how dependent nixpkgs will grow on newer and features and how feasible it is to continue using Nix 2.3. The compat code that will be immediately removed looks like it doesn't actually affect Nix 2.3.18 which already had some fixes backported: - NixOS/nixpkgs#433101. Some features of fileset won't work anymore, but fileset is disallowed in nixpkgs anyways. The documentation workaround only affects Nix < 2.3.5. - NixOS/nixpkgs#433055. The fix for NIX_ATTRS_* has been backported to Nix 2.3.18.
MattSturgeon
approved these changes
Aug 17, 2025
nixpkgs-ci
bot
added
the
12.approvals: 1
wolfgangwalther
commented
Aug 22, 2025
| in | ||
| "Function called without required argument \"${arg}\" at " | ||
| + "${loc'}${prettySuggestions (getSuggestions arg)}"; | ||
| + "${loc.file}:${loc.line}${prettySuggestions (getSuggestions arg)}"; |
Contributor
Author
There was a problem hiding this comment.
Looks like this change doesn't quite work, yet. The error message in https://github.com/NixOS/nixpkgs/actions/runs/17161276034/job/48690946895 is:
… while evaluating a path segment
at /nix/store/jabhxzs8rhw9gv4y7vlz4qrd85rsi9qv-source/lib/customisation.nix:290:24:
289| "Function called without required argument \"${arg}\" at "
290| + "${loc.file}:${loc.line}${prettySuggestions (getSuggestions arg)}";
| ^
291|
error: cannot coerce an integer to a string: 9
Contributor
There was a problem hiding this comment.
Looks like we just missed that it still needs toString. I'll open a PR
Contributor
There was a problem hiding this comment.
Looking closer, I'm also skeptical of directly interpolating loc.file. Is it guaranteed to be a string not a path value?
If it's a path value then direct interpolation would result in creating a new store object.
Contributor
Author
There was a problem hiding this comment.
That looks like a string to me:
nix-repl> builtins.unsafeGetAttrPos "meta" hello
{
column = 17;
file = "[...]/pkgs/stdenv/generic/make-derivation.nix";
line = 881;
}
Contributor
There was a problem hiding this comment.
That looks like a string to me:
Ah for some reason I had the module system in mind, where I'm not sure if _file is allowed to be a path value.
If unsafeGetAttrPos always uses a string for file, consistently accross versions/implementations, then I guess we don't need to toString or + it.
13 tasks
sternenseemann
added a commit
to sternenseemann/nix
that referenced
this pull request
Sep 1, 2025
See NixOS/nixpkgs@fa0cba1. We'll see how dependent nixpkgs will grow on newer and features and how feasible it is to continue using Nix 2.3. The compat code that will be immediately removed looks like it doesn't actually affect Nix 2.3.18 which already had some fixes backported: - NixOS/nixpkgs#433101. Some features of fileset won't work anymore, but fileset is disallowed in nixpkgs anyways. The documentation workaround only affects Nix < 2.3.5. - NixOS/nixpkgs#433055. The fix for NIX_ATTRS_* has been backported to Nix 2.3.18.
tazjin
pushed a commit
to tvlfyi/nix
that referenced
this pull request
Sep 2, 2025
See NixOS/nixpkgs@fa0cba1. We'll see how dependent nixpkgs will grow on newer and features and how feasible it is to continue using Nix 2.3. The compat code that will be immediately removed looks like it doesn't actually affect Nix 2.3.18 which already had some fixes backported: - NixOS/nixpkgs#433101. Some features of fileset won't work anymore, but fileset is disallowed in nixpkgs anyways. The documentation workaround only affects Nix < 2.3.5. - NixOS/nixpkgs#433055. The fix for NIX_ATTRS_* has been backported to Nix 2.3.18.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #428076, we raised
lib/minver.nixto 2.18. This allows some cleanup aroundlib.fileset. The cleanup inlib/customisationwas probably already possible before.Things done
Add a 👍 reaction to pull requests you find important.