Skip to content

nixos-rebuild-ng: remove conditionals for Nix < 2.18#433056

Merged
wolfgangwalther merged 1 commit intoNixOS:masterfrom
wolfgangwalther:minver-nixos-rebuild-ng
Aug 12, 2025
Merged

nixos-rebuild-ng: remove conditionals for Nix < 2.18#433056
wolfgangwalther merged 1 commit intoNixOS:masterfrom
wolfgangwalther:minver-nixos-rebuild-ng

Conversation

@wolfgangwalther
Copy link
Contributor

@wolfgangwalther wolfgangwalther commented Aug 12, 2025 •
edited
Loading

We have recently raised Nixpkgs' minver to 2.18, thus a lot of conditionals are not required anymore.

Things done

Add a 👍 reaction to pull requests you find important.

@wolfgangwalther
nixos-rebuild-ng: remove conditionals for Nix < 2.18
febce22 
We have recently raised Nixpkgs' minver to 2.18, thus a lot of
conditionals are not required anymore.
@nix-owners nix-owners bot requested a review from thiagokokada August 12, 2025 10:26
@wolfgangwalther wolfgangwalther mentioned this pull request Aug 12, 2025
Merged
2 tasks
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS labels Aug 12, 2025
@thiagokokada
Copy link
Contributor

thiagokokada commented Aug 12, 2025

There are some CI errors but they don't seem to be related to this PR, but can you confirm @wolfgangwalther?

@wolfgangwalther
Copy link
Contributor Author

wolfgangwalther commented Aug 12, 2025

CI errors, where? I can't see any.

(currently running nixpkgs-review, let's see what that says, too)

@thiagokokada
Copy link
Contributor

thiagokokada commented Aug 12, 2025

CI errors, where? I can't see any.

(currently running nixpkgs-review, let's see what that says, too)

       … while evaluating attribute 'args' of derivation 'bootstrap-stage0-glibc-bootstrapFiles'
         at /var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/ofborg-core/pkgs/stdenv/generic/make-derivation.nix:510:13:
          509|             builder = attrs.realBuilder or stdenv.shell;
          510|             args =
             |             ^
          511|               attrs.args or [

       error: cannot open connection to remote store 'daemon': error: reading from file: Connection reset by peer

You can see the full log here:

@wolfgangwalther
Copy link
Contributor Author

wolfgangwalther commented Aug 12, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 433056
Commit: febce22a822edc44fc7c22f0115bb6ea12b9b2e6

x86_64-linux

⏩ 1 package blacklisted:
  • tests.nixos-functions.nixos-test
✅ 7 packages built:
  • nixos-rebuild-ng
  • nixos-rebuild-ng.dist
  • tests.devShellTools.nixos
  • tests.testers.lycheeLinkCheck.network
  • tests.testers.nixosTest-example
  • tests.testers.runNixOSTest-example (tests.testers.runNixOSTest-extendNixOS)
  • tests.trivial-builders.references

aarch64-linux

⏩ 1 package blacklisted:
  • tests.nixos-functions.nixos-test
✅ 7 packages built:
  • nixos-rebuild-ng
  • nixos-rebuild-ng.dist
  • tests.devShellTools.nixos
  • tests.testers.lycheeLinkCheck.network
  • tests.testers.nixosTest-example
  • tests.testers.runNixOSTest-example (tests.testers.runNixOSTest-extendNixOS)
  • tests.trivial-builders.references

x86_64-darwin

✅ 2 packages built:
  • nixos-rebuild-ng
  • nixos-rebuild-ng.dist

aarch64-darwin

✅ 2 packages built:
  • nixos-rebuild-ng
  • nixos-rebuild-ng.dist

@wolfgangwalther
Copy link
Contributor Author

wolfgangwalther commented Aug 12, 2025

Ah, ofborg I see. These appear as "skipped", so I didn't expect any failures to hide behind these. Yes, I agree, these seem like unrelated to this PR. Also nixpkgs-review is happy on all platforms, so I guess we are, too.

Still running the passthru tests again, though.

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Aug 12, 2025
@thiagokokada
Copy link
Contributor

thiagokokada commented Aug 12, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 433056
Commit: febce22a822edc44fc7c22f0115bb6ea12b9b2e6

aarch64-linux

⏩ 1 package blacklisted:
  • tests.nixos-functions.nixos-test
❌ 5 packages failed to build:
  • tests.devShellTools.nixos
  • tests.testers.lycheeLinkCheck.network
  • tests.testers.nixosTest-example
  • tests.testers.runNixOSTest-example (tests.testers.runNixOSTest-extendNixOS)
  • tests.trivial-builders.references
✅ 2 packages built:
  • nixos-rebuild-ng
  • nixos-rebuild-ng.dist

@thiagokokada
Copy link
Contributor

thiagokokada commented Aug 12, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 433056
Commit: febce22a822edc44fc7c22f0115bb6ea12b9b2e6

aarch64-darwin

✅ 2 packages built:
  • nixos-rebuild-ng
  • nixos-rebuild-ng.dist

@thiagokokada
Copy link
Contributor

thiagokokada commented Aug 12, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 433056
Commit: febce22a822edc44fc7c22f0115bb6ea12b9b2e6

x86_64-darwin

✅ 2 packages built:
  • nixos-rebuild-ng
  • nixos-rebuild-ng.dist

@thiagokokada
Copy link
Contributor

thiagokokada commented Aug 12, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 433056
Commit: febce22a822edc44fc7c22f0115bb6ea12b9b2e6

x86_64-linux

⏩ 1 package blacklisted:
  • tests.nixos-functions.nixos-test
✅ 7 packages built:
  • nixos-rebuild-ng
  • nixos-rebuild-ng.dist
  • tests.devShellTools.nixos
  • tests.testers.lycheeLinkCheck.network
  • tests.testers.nixosTest-example
  • tests.testers.runNixOSTest-example (tests.testers.runNixOSTest-extendNixOS)
  • tests.trivial-builders.references

@wolfgangwalther
Copy link
Contributor Author

wolfgangwalther commented Aug 12, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 433056 --package nixos-rebuild-ng.tests
Commit: febce22a822edc44fc7c22f0115bb6ea12b9b2e6

x86_64-linux

✅ 16 packages built:
  • nixos-rebuild-ng.tests.linters
  • nixos-rebuild-ng.tests.nixos-rebuild-specialisations-ng
  • nixos-rebuild-ng.tests.nixos-rebuild-target-host-ng
  • nixos-rebuild-ng.tests.repl
  • nixos-rebuild-ng.tests.with_lix_latest
  • nixos-rebuild-ng.tests.with_lix_latest.dist (nixos-rebuild-ng.tests.with_lix_latest.dist.dist)
  • nixos-rebuild-ng.tests.with_lix_stable
  • nixos-rebuild-ng.tests.with_lix_stable.dist (nixos-rebuild-ng.tests.with_lix_stable.dist.dist)
  • nixos-rebuild-ng.tests.with_nix_2_24
  • nixos-rebuild-ng.tests.with_nix_2_24.dist (nixos-rebuild-ng.tests.with_nix_2_24.dist.dist)
  • nixos-rebuild-ng.tests.with_nix_latest
  • nixos-rebuild-ng.tests.with_nix_latest.dist (nixos-rebuild-ng.tests.with_nix_latest.dist.dist)
  • nixos-rebuild-ng.tests.with_nix_stable
  • nixos-rebuild-ng.tests.with_nix_stable.dist (nixos-rebuild-ng.tests.with_nix_stable.dist.dist)
  • nixos-rebuild-ng.tests.with_reexec
  • nixos-rebuild-ng.tests.with_reexec.dist (nixos-rebuild-ng.tests.with_reexec.dist.dist)

aarch64-linux

✅ 15 packages built:
  • nixos-rebuild-ng.tests.linters
  • nixos-rebuild-ng.tests.nixos-rebuild-target-host-ng
  • nixos-rebuild-ng.tests.repl
  • nixos-rebuild-ng.tests.with_lix_latest
  • nixos-rebuild-ng.tests.with_lix_latest.dist (nixos-rebuild-ng.tests.with_lix_latest.dist.dist)
  • nixos-rebuild-ng.tests.with_lix_stable
  • nixos-rebuild-ng.tests.with_lix_stable.dist (nixos-rebuild-ng.tests.with_lix_stable.dist.dist)
  • nixos-rebuild-ng.tests.with_nix_2_24
  • nixos-rebuild-ng.tests.with_nix_2_24.dist (nixos-rebuild-ng.tests.with_nix_2_24.dist.dist)
  • nixos-rebuild-ng.tests.with_nix_latest
  • nixos-rebuild-ng.tests.with_nix_latest.dist (nixos-rebuild-ng.tests.with_nix_latest.dist.dist)
  • nixos-rebuild-ng.tests.with_nix_stable
  • nixos-rebuild-ng.tests.with_nix_stable.dist (nixos-rebuild-ng.tests.with_nix_stable.dist.dist)
  • nixos-rebuild-ng.tests.with_reexec
  • nixos-rebuild-ng.tests.with_reexec.dist (nixos-rebuild-ng.tests.with_reexec.dist.dist)

@wolfgangwalther wolfgangwalther merged commit c70c79d into NixOS:master Aug 12, 2025
38 of 40 checks passed
@wolfgangwalther wolfgangwalther deleted the minver-nixos-rebuild-ng branch August 12, 2025 11:44
@wolfgangwalther
Copy link
Contributor Author

wolfgangwalther commented Aug 12, 2025

Thanks for the very quick review!

thiagokokada added a commit to thiagokokada/nixpkgs that referenced this pull request Dec 3, 2025
@thiagokokada
nixos-rebuild-ng: remove test for multiple versions of Nix/Lix
3771589 
It is not necessary anymore since we don't do conditional features based
on Nix version since NixOS#433056.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thiagokokada thiagokokada thiagokokada approved these changes

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wolfgangwalther @thiagokokada